-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Detect file changes #135
Open
aaxu
wants to merge
41
commits into
google:master
Choose a base branch
from
aaxu:enhancement/fileHasChanged
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Detect file changes #135
Changes from all commits
Commits
Show all changes
41 commits
Select commit
Hold shift + click to select a range
bbbc209
Create background thread to constantly check the file stats of a give…
aaxu f27975c
Changed all references to self.isReadOnly to use the FileStats object
aaxu bde81a9
Modified program to use the FileStats object
aaxu 994a3e3
Fixed calls to start monitoring the correct file one at a time
aaxu 680ff5c
Gave the fileStats object reference to the text buffer so that it can…
aaxu 13514cc
Changed from rendering the topInfo window to rerendering the entire w…
aaxu 5141adc
Changed implementation to make the filestats object talk to the backg…
aaxu d78721f
Fixed program from crashing due to returning from bg thread early
aaxu ba39a45
Made filestats thread work correctly and refactored the background fu…
aaxu 1ec739e
Made only one function in fileStats that returns all the data that th…
aaxu b3295d4
Implemented single-threaded version for fileStats and fixed redo chai…
aaxu d4df6dc
Fixed synch issue which also fixed the fileStats thread when running …
aaxu c149754
Add empty line to end of file
aaxu d0eb68c
Update old comments since arguments were changed after refactoring an…
aaxu 91ddfd1
Fix isSafeToWrite function to utilize the fileStats object
aaxu c744b86
Fixed comments and moved fileLoad and setting fileStats attributes ba…
aaxu 7cdee9a
Now if renameBuffer is called, the function will also modify the file…
aaxu e19b73f
Moved the saved file stats to the FileStats object and created a file…
aaxu 6145283
Created new controller and window for popup messages. Still need to f…
aaxu 47c1256
Added basic rendering and integration of the popup window
aaxu 237c802
Fixed the check condition for the FileStats thread to detect file cha…
aaxu 4afcef4
Added check that prevents this function from breaking before some att…
aaxu 502ebcd
Added better support for changing files to track and can check if fil…
aaxu 085addd
Created a new function that checks if a file's content has changed. T…
aaxu ffcb070
Got popup window to kind of display. Need a lot of polishing
aaxu 799d681
Fixed positioning of the popup window. Need to fix format and colorin…
aaxu 4661eda
Fixed the layout of the popup textbox. Need to fix color and add Y/N …
aaxu 048ad10
Add comment
aaxu 2f575d9
Added options parameter for the popup window, improved the format of …
aaxu decf88f
Stopped fileStats thread when waiting for user input. Need to make it…
aaxu 105d9ab
Made new functions that check whether file has changed since save and…
aaxu 0c35651
Background output now contains objects of (frame, callerSemaphore). F…
aaxu 48252e6
Changed color of the popup window and added support for 8 color termi…
aaxu dbce963
Cleaned up code and fixed a bug that would sometimes appear if tempCh…
aaxu 4474831
Overrode setTextBuffer method so that it tells controller when the po…
aaxu c8de77f
Added copyright comment to file_stats.py
aaxu 0bcfd0c
Merge with updated master
aaxu cf38871
Readd deleted line which fixes parsing issues and rebased to master
aaxu bb915ba
Merged with master. Need to test and set popup options for fileStat t…
aaxu 4ec9d8e
Fixed the fileStats thread to work with the new popup window from mas…
aaxu 0c68f39
Merge with master
aaxu File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can the pop-up simply be a top level modal window in the ci_program.py zOrder, so that background.py wouldn't need to know anything about it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What do you mean by this? I'm making it so that the FileStats object contacts the background thread, and the background thread contacts the main thread. Right now background.py doesn't really know anything about the pop-up and it's just redirecting it to the main thread.