-
Notifications
You must be signed in to change notification settings - Fork 437
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add npm ci check #118
Add npm ci check #118
Conversation
For an example of how a travis failure looks when package-lock.json hasn't been updated, see https://travis-ci.org/ajlai/clasp/jobs/367926019 |
I appreciate the PR, but I don't think this PR speeds up the build. I'd remove |
My original goal wasn't to speed up the build (although that would have been nice). It's just to make sure package-lock.json gets updated and checked in when the package.json does. |
LGTM after those changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Looks good.
npm 5.8.0 has a new command npm-ci which functions like
npm install
but also checks that the package-lock.json is up to date with the package.json file.This PR changes the travis config to use
npm ci
.#126