-
Notifications
You must be signed in to change notification settings - Fork 437
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Creates tests for clasp clone and clasp pull #119
Conversation
When running clasp clone test make sure you put in a script ID. Signed-off-by: campionfellin <campionfellin@gmail.com>
Pull Request Test Coverage Report for Build 74
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks pretty good.
2 comments.
tests/test.ts
Outdated
@@ -43,6 +43,31 @@ describe.skip('Test clasp create function', () => { | |||
}); | |||
}); | |||
|
|||
// When running this test, please put in a script ID |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What do you mean "put in a script ID"?
Can we first create a test script ID, then clone it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, we can do one and hard code it for everyone, if you think that's better. Or use the one from the clasp create test.
tests/test.ts
Outdated
@@ -43,6 +43,31 @@ describe.skip('Test clasp create function', () => { | |||
}); | |||
}); | |||
|
|||
// When running this test, please put in a script ID | |||
// then use `sudo npm run build` before running test. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't you need to build before any test?
Shouldn't we have this in the file header comment if that is the case?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah good point
Not sure where the |
Not sure on the coveralls issue either... Looks like it's been pretty steady at |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Marking "Request changes" in GH for the comments.
It now uses the .clasp.json file made by the clasp create function before it Signed-off-by: campionfellin <campionfellin@gmail.com>
Signed-off-by: campionfellin <campionfellin@gmail.com>
Signed-off-by: campionfellin <campionfellin@gmail.com>
Though coveralls will likely report differently, it looks like this brings overall coverage to |
Seeing |
So this is because some of the tests can't be run on Travis so they are skipped. If you run locally and un-skip every test, this is the output:
|
When running clasp clone test make sure you put in a script ID.
Signed-off-by: campionfellin campionfellin@gmail.com