Convert clasp create to inquirer functionality #130
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now, if you don't specify a script name, we use inquirer to ask for one. Also added tests for this. Signed-off-by: campionfellin <campionfellin@gmail.com>
campionfellin
commented
Apr 23, 2018
index.ts
Outdated
| @@ -606,7 +624,7 @@ commander | |||
| logError(error, ERROR.CREATE); | |||
| }); | |||
| }); | |||
| }); | |||
| }); | |||
There was a problem hiding this comment.
Looks like we should also add no-trailing-whitespace (https://palantir.github.io/tslint/rules/no-trailing-whitespace/) to the tslint
Pull Request Test Coverage Report for Build 92
💛 - Coveralls |
grant
reviewed
Apr 23, 2018
index.ts
Outdated
| @@ -209,6 +210,16 @@ Did you provide the correct scriptId?`, | |||
| UNAUTHENTICATED: 'Error: Unauthenticated request: Please try again.', | |||
| }; | |||
|
|
|||
| // Questions (prompts) for clasp create | |||
| const createQuestions = [ | |||
| { | |||
index.ts
Outdated
| @@ -209,6 +210,16 @@ Did you provide the correct scriptId?`, | |||
| UNAUTHENTICATED: 'Error: Unauthenticated request: Please try again.', | |||
| }; | |||
|
|
|||
| // Questions (prompts) for clasp create | |||
| const createQuestions = [ | |||
index.ts
Outdated
| type : 'input', | ||
| name : 'title', | ||
| message : 'give a script title: ', | ||
| default: LOG.UNTITLED_SCRIPT_TITLE |
index.ts
Outdated
| @@ -606,7 +624,7 @@ commander | |||
| logError(error, ERROR.CREATE); | |||
| }); | |||
| }); | |||
| }); | |||
| }); | |||
Add no-trailing-whitespace and trailing-comma to tslint Fix lint errors Signed-off-by: campionfellin <campionfellin@gmail.com>
grant
approved these changes
Apr 23, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now, if you don't specify a script name, we use inquirer to ask for one.
Also added tests for this.
Signed-off-by: campionfellin campionfellin@gmail.com
Addresses #57
npm run testsucceeds.