Add headless oauth support #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grant
suggested changes
Jan 26, 2018
index.js
Outdated
| @@ -40,6 +40,9 @@ const recursive = require('recursive-readdir'); | |||
| const Spinner = require('cli-spinner').Spinner; | |||
| const splitLines = require('split-lines'); | |||
| const url = require('url'); | |||
| const readline = require('readline'); | |||
|
|
|||
index.js
Outdated
| */ | ||
| function authorizeWithLocalhost(opts) { | ||
| return new Promise((resolve, reject) => { | ||
| var server = http.createServer(function(req, res) { |
index.js
Outdated
| function authorizeWithLocalhost(opts) { | ||
| return new Promise((resolve, reject) => { | ||
| var server = http.createServer(function(req, res) { | ||
| var url_parts = url.parse(req.url, true); |
There was a problem hiding this comment.
Use urlParts. No snake case. Here and elsewhere.
index.js
Outdated
| reject(err); | ||
| } else { | ||
| res(token); | ||
| } |
There was a problem hiding this comment.
Let's shorten when possible:
if (err) return reject(err);
return res(token);
index.js
Outdated
| * to handle the auth response. False if manual entry used. | ||
| */ | ||
| function authorize(useLocalhost) { | ||
| var opts = { |
There was a problem hiding this comment.
Use let instead of var everywhere.
index.js
Outdated
| function authorizeWithoutLocalhost(opts) { | ||
| oauth2Client._redirectUri = REDIRECT_URI_OOB; | ||
| var authUrl = oauth2Client.generateAuthUrl(opts); | ||
|
|
index.js
Outdated
| } | ||
| var authCode = useLocalhost ? | ||
| authorizeWithLocalhost(opts) : | ||
| authorizeWithoutLocalhost(opts); |
index.js
Outdated
| server.shutdown(); | ||
| }).withShutdown(); | ||
|
|
||
| server.listen(0, () => { |
There was a problem hiding this comment.
Listen on port 0? I assume it's not in use. o.w. we'll get ERR_SERVER_ALREADY_LISTEN.
There was a problem hiding this comment.
0 just means pick an unused ephemeral port. For installed app flows, port is ignored for registered callback localhost URLs, specifically for this reason -- hardcoded ports can cause conflicts if there's already a service running on it.
|
Fixes #2. |
|
PTAL |
This was referenced Jun 20, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds --no-localhost option to login command + refactors auth a little.
Planning a subsequent change to upgrade the client lib & auth library to the recently released version (v25.x for client, v1.x) since the new auth library has support for code_verifier in the oauth flow which will makes things more secure.