Update google api client to v25.x, enable code challenge/verifier #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r improved oauth security
grant
suggested changes
Jan 28, 2018
| let opts = { | ||
| access_type: 'offline', | ||
| scope: [ | ||
| 'https://www.googleapis.com/auth/script.deployments', | ||
| 'https://www.googleapis.com/auth/script.projects', | ||
| ], | ||
| } | ||
| code_challenge_method: 'S256', |
There was a problem hiding this comment.
Please include a link to:
https://developers.google.com/identity/protocols/OAuth2InstalledApp#step1-code-verifier
index.js
Outdated
| }) | ||
| }) | ||
| .then(token => DOTFILE.RC.write(token)) | ||
| authCode.then(code => oauth2Client.getToken({ code: code, codeVerifier: codes.codeVerifier })) |
There was a problem hiding this comment.
- Destructure when possible.
- Line too long
authCode.then(code => oauth2Client.getToken({
code,
codeVerifier: codes.codeVerifier
}))
index.js
Outdated
| @@ -442,7 +439,7 @@ program | |||
| if (error) { | |||
| logError(error, ERROR.CREATE); | |||
| } else { | |||
| let scriptId = res.scriptId; | |||
| let scriptId = res.data.scriptId; | |||
There was a problem hiding this comment.
Please destructure data here and elsewhere in the function callback above.
- script.projects.create({ title, parentId }, {}, (error, res) => {
+ script.projects.create({ title, parentId }, {}, (error, {data}) => {
|
Updated |
grant
approved these changes
Jan 28, 2018
|
Thanks! Will push to |
sqrrrl
pushed a commit
that referenced
this pull request
May 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See https://developers.google.com/identity/protocols/OAuth2InstalledApp#step1-code-verifier for details about the protocol change.