Cleanup before next pr #621
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
use forEach instead of map when return value is not used (google#614)
Dependencies (google#615)
grant
reviewed
May 20, 2019
grant
reviewed
May 20, 2019
grant
reviewed
May 20, 2019
grant
reviewed
May 20, 2019
|
Thanks! |
|
Welcome @grant Who implemented the |
|
Not sure what you're referring to. Use git blame to find out who implemented it here. |
|
#394 is the PR where package @takanakahiko since the above PR is yours, can you give your opinion? |
|
@PopGoesTheWza Line 41 in 267209d |
|
@takanakahiko thanks I am almost done in refactoring all |
|
Note, if you want to move the autocomplete logic to it's own file, that would be great! |
|
@grant I moved as much as possible inside inquirer.ts (cf. Open PR) |
PopGoesTheWza
added a commit
to PopGoesTheWza/clasp
that referenced
this pull request
May 22, 2019
* prettier + sort imports * splitLines types * unused package 'connect' * ucfirst, isOnline types * ellipsize types * redundant package 'fs-copy-file-sync' * removing extra line * // TODO * packages dependencies update * comment fix * fixes * nicer ellipsize typing * better?
grant
pushed a commit
that referenced
this pull request
May 22, 2019
* 2.1.0 * Low impact changes (#619) * dependencies clean-up * types for child_process' spawnSync * types for child_process' spawnSync + options fix * linting * Relative rootdir (#620) * relative rootDir support * relative rootDir support (untrackedFiles behavior changed) * relative rootDir doc changes * Cleanup before next pr (#621) * prettier + sort imports * splitLines types * unused package 'connect' * ucfirst, isOnline types * ellipsize types * redundant package 'fs-copy-file-sync' * removing extra line * // TODO * packages dependencies update * comment fix * fixes * nicer ellipsize typing * better? * Refactor `inquirer` package (#622) * regroup `inquirer` into a single file * fix typo * linting * switch to `find-up` * switch to `find-up` & `strip-bom` * dependencies update * findUp implementation fix * enum accessor fix * fs-extra & typescript dependency fix * linting * dependencies clean-up (again) * non any cast * TODOs & types
grant
pushed a commit
that referenced
this pull request
May 23, 2019
* 2.1.0 * Low impact changes (#619) * dependencies clean-up * types for child_process' spawnSync * types for child_process' spawnSync + options fix * linting * Relative rootdir (#620) * relative rootDir support * relative rootDir support (untrackedFiles behavior changed) * relative rootDir doc changes * Cleanup before next pr (#621) * prettier + sort imports * splitLines types * unused package 'connect' * ucfirst, isOnline types * ellipsize types * redundant package 'fs-copy-file-sync' * removing extra line * // TODO * packages dependencies update * comment fix * fixes * nicer ellipsize typing * better? * Refactor `inquirer` package (#622) * regroup `inquirer` into a single file * fix typo * linting * switch to `find-up` * switch to `find-up` & `strip-bom` * dependencies update * findUp implementation fix * enum accessor fix * fs-extra & typescript dependency fix * linting * dependencies clean-up (again) * non any cast * TODOs & types * dependencies * relative paths fix * relative paths fix, types & minor code changes * commented-out cleanup
grant
pushed a commit
that referenced
this pull request
Jun 14, 2019
* 2.1.0 * Low impact changes (#619) * dependencies clean-up * types for child_process' spawnSync * types for child_process' spawnSync + options fix * linting * Relative rootdir (#620) * relative rootDir support * relative rootDir support (untrackedFiles behavior changed) * relative rootDir doc changes * Cleanup before next pr (#621) * prettier + sort imports * splitLines types * unused package 'connect' * ucfirst, isOnline types * ellipsize types * redundant package 'fs-copy-file-sync' * removing extra line * // TODO * packages dependencies update * comment fix * fixes * nicer ellipsize typing * better? * Refactor `inquirer` package (#622) * regroup `inquirer` into a single file * fix typo * linting * switch to `find-up` * switch to `find-up` & `strip-bom` * dependencies update * findUp implementation fix * enum accessor fix * fs-extra & typescript dependency fix * linting * dependencies clean-up (again) * non any cast * tsconfig.json doc * resolving
grant
pushed a commit
that referenced
this pull request
Jun 14, 2019
…option (#645) * 2.1.0 * Low impact changes (#619) * dependencies clean-up * types for child_process' spawnSync * types for child_process' spawnSync + options fix * linting * Relative rootdir (#620) * relative rootDir support * relative rootDir support (untrackedFiles behavior changed) * relative rootDir doc changes * Cleanup before next pr (#621) * prettier + sort imports * splitLines types * unused package 'connect' * ucfirst, isOnline types * ellipsize types * redundant package 'fs-copy-file-sync' * removing extra line * // TODO * packages dependencies update * comment fix * fixes * nicer ellipsize typing * better? * Refactor `inquirer` package (#622) * regroup `inquirer` into a single file * fix typo * linting * switch to `find-up` * switch to `find-up` & `strip-bom` * dependencies update * findUp implementation fix * enum accessor fix * fs-extra & typescript dependency fix * linting * dependencies clean-up (again) * non any cast * tsconfig.json doc * pass `rootDir` with `manifestExists()` * resolving
grant
pushed a commit
that referenced
this pull request
Jun 14, 2019
* 2.1.0 * Low impact changes (#619) * dependencies clean-up * types for child_process' spawnSync * types for child_process' spawnSync + options fix * linting * Relative rootdir (#620) * relative rootDir support * relative rootDir support (untrackedFiles behavior changed) * relative rootDir doc changes * Cleanup before next pr (#621) * prettier + sort imports * splitLines types * unused package 'connect' * ucfirst, isOnline types * ellipsize types * redundant package 'fs-copy-file-sync' * removing extra line * // TODO * packages dependencies update * comment fix * fixes * nicer ellipsize typing * better? * Refactor `inquirer` package (#622) * regroup `inquirer` into a single file * fix typo * linting * switch to `find-up` * switch to `find-up` & `strip-bom` * dependencies update * findUp implementation fix * enum accessor fix * fs-extra & typescript dependency fix * linting * dependencies clean-up (again) * non any cast * Error message fix
grant
pushed a commit
that referenced
this pull request
Jun 27, 2019
* 2.1.0 * Low impact changes (#619) * dependencies clean-up * types for child_process' spawnSync * types for child_process' spawnSync + options fix * linting * Relative rootdir (#620) * relative rootDir support * relative rootDir support (untrackedFiles behavior changed) * relative rootDir doc changes * Cleanup before next pr (#621) * prettier + sort imports * splitLines types * unused package 'connect' * ucfirst, isOnline types * ellipsize types * redundant package 'fs-copy-file-sync' * removing extra line * // TODO * packages dependencies update * comment fix * fixes * nicer ellipsize typing * better? * Refactor `inquirer` package (#622) * regroup `inquirer` into a single file * fix typo * linting * switch to `find-up` * switch to `find-up` & `strip-bom` * dependencies update * findUp implementation fix * enum accessor fix * fs-extra & typescript dependency fix * linting * dependencies clean-up (again) * non any cast * packages update * enable and switch to proper es module import syntax
grant
pushed a commit
that referenced
this pull request
Jul 3, 2019
* 2.1.0 * Low impact changes (#619) * dependencies clean-up * types for child_process' spawnSync * types for child_process' spawnSync + options fix * linting * Relative rootdir (#620) * relative rootDir support * relative rootDir support (untrackedFiles behavior changed) * relative rootDir doc changes * Cleanup before next pr (#621) * prettier + sort imports * splitLines types * unused package 'connect' * ucfirst, isOnline types * ellipsize types * redundant package 'fs-copy-file-sync' * removing extra line * // TODO * packages dependencies update * comment fix * fixes * nicer ellipsize typing * better? * Refactor `inquirer` package (#622) * regroup `inquirer` into a single file * fix typo * linting * switch to `find-up` * switch to `find-up` & `strip-bom` * dependencies update * findUp implementation fix * enum accessor fix * fs-extra & typescript dependency fix * linting * dependencies clean-up (again) * non any cast * packages update * del@5.0.0 validated
grant
pushed a commit
that referenced
this pull request
Jul 8, 2019
* 2.1.0 * Low impact changes (#619) * dependencies clean-up * types for child_process' spawnSync * types for child_process' spawnSync + options fix * linting * Relative rootdir (#620) * relative rootDir support * relative rootDir support (untrackedFiles behavior changed) * relative rootDir doc changes * Cleanup before next pr (#621) * prettier + sort imports * splitLines types * unused package 'connect' * ucfirst, isOnline types * ellipsize types * redundant package 'fs-copy-file-sync' * removing extra line * // TODO * packages dependencies update * comment fix * fixes * nicer ellipsize typing * better? * Refactor `inquirer` package (#622) * regroup `inquirer` into a single file * fix typo * linting * switch to `find-up` * switch to `find-up` & `strip-bom` * dependencies update * findUp implementation fix * enum accessor fix * fs-extra & typescript dependency fix * linting * dependencies clean-up (again) * non any cast * adding `.html` files to default `appsscript.json` * TODO * added test for `.html` * added `.gs`
grant
pushed a commit
that referenced
this pull request
Jul 22, 2019
* 2.1.0 * Low impact changes (#619) * dependencies clean-up * types for child_process' spawnSync * types for child_process' spawnSync + options fix * linting * Relative rootdir (#620) * relative rootDir support * relative rootDir support (untrackedFiles behavior changed) * relative rootDir doc changes * Cleanup before next pr (#621) * prettier + sort imports * splitLines types * unused package 'connect' * ucfirst, isOnline types * ellipsize types * redundant package 'fs-copy-file-sync' * removing extra line * // TODO * packages dependencies update * comment fix * fixes * nicer ellipsize typing * better? * Refactor `inquirer` package (#622) * regroup `inquirer` into a single file * fix typo * linting * switch to `find-up` * switch to `find-up` & `strip-bom` * dependencies update * findUp implementation fix * enum accessor fix * fs-extra & typescript dependency fix * linting * dependencies clean-up (again) * non any cast * npm audit fix
grant
pushed a commit
that referenced
this pull request
Aug 1, 2019
* 2.1.0 * Low impact changes (#619) * dependencies clean-up * types for child_process' spawnSync * types for child_process' spawnSync + options fix * linting * Relative rootdir (#620) * relative rootDir support * relative rootDir support (untrackedFiles behavior changed) * relative rootDir doc changes * Cleanup before next pr (#621) * prettier + sort imports * splitLines types * unused package 'connect' * ucfirst, isOnline types * ellipsize types * redundant package 'fs-copy-file-sync' * removing extra line * // TODO * packages dependencies update * comment fix * fixes * nicer ellipsize typing * better? * Refactor `inquirer` package (#622) * regroup `inquirer` into a single file * fix typo * linting * switch to `find-up` * switch to `find-up` & `strip-bom` * dependencies update * findUp implementation fix * enum accessor fix * fs-extra & typescript dependency fix * linting * dependencies clean-up (again) * non any cast * clone status * fix clone/create success message * prettier did it * helper * resolve
grant
pushed a commit
that referenced
this pull request
Aug 1, 2019
* 2.1.0 * Low impact changes (#619) * dependencies clean-up * types for child_process' spawnSync * types for child_process' spawnSync + options fix * linting * Relative rootdir (#620) * relative rootDir support * relative rootDir support (untrackedFiles behavior changed) * relative rootDir doc changes * Cleanup before next pr (#621) * prettier + sort imports * splitLines types * unused package 'connect' * ucfirst, isOnline types * ellipsize types * redundant package 'fs-copy-file-sync' * removing extra line * // TODO * packages dependencies update * comment fix * fixes * nicer ellipsize typing * better? * Refactor `inquirer` package (#622) * regroup `inquirer` into a single file * fix typo * linting * switch to `find-up` * switch to `find-up` & `strip-bom` * dependencies update * findUp implementation fix * enum accessor fix * fs-extra & typescript dependency fix * linting * dependencies clean-up (again) * non any cast * issue 666: normalize EOL * Prettier did this * `normalize-newline` added. other packages updated
grant
pushed a commit
that referenced
this pull request
Aug 6, 2019
* 2.1.0 * Low impact changes (#619) * dependencies clean-up * types for child_process' spawnSync * types for child_process' spawnSync + options fix * linting * Relative rootdir (#620) * relative rootDir support * relative rootDir support (untrackedFiles behavior changed) * relative rootDir doc changes * Cleanup before next pr (#621) * prettier + sort imports * splitLines types * unused package 'connect' * ucfirst, isOnline types * ellipsize types * redundant package 'fs-copy-file-sync' * removing extra line * // TODO * packages dependencies update * comment fix * fixes * nicer ellipsize typing * better? * Refactor `inquirer` package (#622) * regroup `inquirer` into a single file * fix typo * linting * switch to `find-up` * switch to `find-up` & `strip-bom` * dependencies update * findUp implementation fix * enum accessor fix * fs-extra & typescript dependency fix * linting * dependencies clean-up (again) * non any cast * refactoring `logError`
grant
pushed a commit
that referenced
this pull request
Aug 21, 2019
* 2.1.0 * Low impact changes (#619) * dependencies clean-up * types for child_process' spawnSync * types for child_process' spawnSync + options fix * linting * Relative rootdir (#620) * relative rootDir support * relative rootDir support (untrackedFiles behavior changed) * relative rootDir doc changes * Cleanup before next pr (#621) * prettier + sort imports * splitLines types * unused package 'connect' * ucfirst, isOnline types * ellipsize types * redundant package 'fs-copy-file-sync' * removing extra line * // TODO * packages dependencies update * comment fix * fixes * nicer ellipsize typing * better? * Refactor `inquirer` package (#622) * regroup `inquirer` into a single file * fix typo * linting * switch to `find-up` * switch to `find-up` & `strip-bom` * dependencies update * findUp implementation fix * enum accessor fix * fs-extra & typescript dependency fix * linting * dependencies clean-up (again) * non any cast * convert to import * commander v3 * no padEnd polyfill with node 8 * less but newer packages * prettier
grant
pushed a commit
that referenced
this pull request
Aug 23, 2019
* 2.1.0 * Low impact changes (#619) * dependencies clean-up * types for child_process' spawnSync * types for child_process' spawnSync + options fix * linting * Relative rootdir (#620) * relative rootDir support * relative rootDir support (untrackedFiles behavior changed) * relative rootDir doc changes * Cleanup before next pr (#621) * prettier + sort imports * splitLines types * unused package 'connect' * ucfirst, isOnline types * ellipsize types * redundant package 'fs-copy-file-sync' * removing extra line * // TODO * packages dependencies update * comment fix * fixes * nicer ellipsize typing * better? * Refactor `inquirer` package (#622) * regroup `inquirer` into a single file * fix typo * linting * switch to `find-up` * switch to `find-up` & `strip-bom` * dependencies update * findUp implementation fix * enum accessor fix * fs-extra & typescript dependency fix * linting * dependencies clean-up (again) * non any cast * import cleanup & TODO resolve * prettier * ch-ch-changes
PopGoesTheWza
added a commit
to PopGoesTheWza/clasp
that referenced
this pull request
Aug 26, 2019
* 2.1.0 * Low impact changes (google#619) * dependencies clean-up * types for child_process' spawnSync * types for child_process' spawnSync + options fix * linting * Relative rootdir (google#620) * relative rootDir support * relative rootDir support (untrackedFiles behavior changed) * relative rootDir doc changes * Cleanup before next pr (google#621) * prettier + sort imports * splitLines types * unused package 'connect' * ucfirst, isOnline types * ellipsize types * redundant package 'fs-copy-file-sync' * removing extra line * // TODO * packages dependencies update * comment fix * fixes * nicer ellipsize typing * better? * Refactor `inquirer` package (google#622) * regroup `inquirer` into a single file * fix typo * linting * switch to `find-up` * switch to `find-up` & `strip-bom` * dependencies update * findUp implementation fix * enum accessor fix * fs-extra & typescript dependency fix * linting * dependencies clean-up (again) * non any cast * import cleanup & TODO resolve * prettier * ch-ch-changes
grant
pushed a commit
that referenced
this pull request
Aug 30, 2019
* 2.1.0 * Low impact changes (#619) * dependencies clean-up * types for child_process' spawnSync * types for child_process' spawnSync + options fix * linting * Relative rootdir (#620) * relative rootDir support * relative rootDir support (untrackedFiles behavior changed) * relative rootDir doc changes * Cleanup before next pr (#621) * prettier + sort imports * splitLines types * unused package 'connect' * ucfirst, isOnline types * ellipsize types * redundant package 'fs-copy-file-sync' * removing extra line * // TODO * packages dependencies update * comment fix * fixes * nicer ellipsize typing * better? * Refactor `inquirer` package (#622) * regroup `inquirer` into a single file * fix typo * linting * switch to `find-up` * switch to `find-up` & `strip-bom` * dependencies update * findUp implementation fix * enum accessor fix * fs-extra & typescript dependency fix * linting * dependencies clean-up (again) * non any cast * change default `.claspignore` * changes * exit code 0 or null * test stderr * log err * log err * move `setupTmpDirectory()` to functions.ts * run test from tmp folder * error log * display default * check tmpdir * silly typo * cleanup * cleanup * stderr check * TODOs * cleanup * doc doc * package update * revert inquirer 7.x to 6.x * revert * enums key type declaration * packages
grant
pushed a commit
that referenced
this pull request
Sep 6, 2019
* 2.1.0 * Low impact changes (#619) * dependencies clean-up * types for child_process' spawnSync * types for child_process' spawnSync + options fix * linting * Relative rootdir (#620) * relative rootDir support * relative rootDir support (untrackedFiles behavior changed) * relative rootDir doc changes * Cleanup before next pr (#621) * prettier + sort imports * splitLines types * unused package 'connect' * ucfirst, isOnline types * ellipsize types * redundant package 'fs-copy-file-sync' * removing extra line * // TODO * packages dependencies update * comment fix * fixes * nicer ellipsize typing * better? * Refactor `inquirer` package (#622) * regroup `inquirer` into a single file * fix typo * linting * switch to `find-up` * switch to `find-up` & `strip-bom` * dependencies update * findUp implementation fix * enum accessor fix * fs-extra & typescript dependency fix * linting * dependencies clean-up (again) * non any cast * unnecessary `sudo` * package update * node version req & scripts update
grant
pushed a commit
that referenced
this pull request
Sep 6, 2019
* 2.1.0 * Low impact changes (#619) * dependencies clean-up * types for child_process' spawnSync * types for child_process' spawnSync + options fix * linting * Relative rootdir (#620) * relative rootDir support * relative rootDir support (untrackedFiles behavior changed) * relative rootDir doc changes * Cleanup before next pr (#621) * prettier + sort imports * splitLines types * unused package 'connect' * ucfirst, isOnline types * ellipsize types * redundant package 'fs-copy-file-sync' * removing extra line * // TODO * packages dependencies update * comment fix * fixes * nicer ellipsize typing * better? * Refactor `inquirer` package (#622) * regroup `inquirer` into a single file * fix typo * linting * switch to `find-up` * switch to `find-up` & `strip-bom` * dependencies update * findUp implementation fix * enum accessor fix * fs-extra & typescript dependency fix * linting * dependencies clean-up (again) * non any cast * travis without sudo
PopGoesTheWza
added a commit
that referenced
this pull request
Jan 13, 2020
* 2.1.0 * Low impact changes (#619) * dependencies clean-up * types for child_process' spawnSync * types for child_process' spawnSync + options fix * linting * Relative rootdir (#620) * relative rootDir support * relative rootDir support (untrackedFiles behavior changed) * relative rootDir doc changes * Cleanup before next pr (#621) * prettier + sort imports * splitLines types * unused package 'connect' * ucfirst, isOnline types * ellipsize types * redundant package 'fs-copy-file-sync' * removing extra line * // TODO * packages dependencies update * comment fix * fixes * nicer ellipsize typing * better? * Refactor `inquirer` package (#622) * regroup `inquirer` into a single file * fix typo * linting * switch to `find-up` * switch to `find-up` & `strip-bom` * dependencies update * findUp implementation fix * enum accessor fix * fs-extra & typescript dependency fix * linting * dependencies clean-up (again) * non any cast * minor edits * local calsp & minor edits * moving local clasp to own doc * npm audit fix Co-authored-by: Grant Timmerman <granttimmerman@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes no issue
npm run testsucceeds.npm run lintsucceeds.Some clean-up before I attempt a PR to specify dot files from cli options and environment variables.