Improve output (and suppress GaxiosError) on failed push #857

Nu11u5 · 2021-07-02T15:35:04Z

Fixes #827, #907

Suppresses GaxiosError object dump on failed push
Instead, only error.message is output to the console
Always calls stopSpinner() before outputting to console
Only shows project file list and success message when no error is thrown
Formats syntax error message file path and line number as parsable by IDEs
Outputs formatted code snippet of the error line

Checklist

npm run test succeeds.
npm run lint succeeds.
Appropriate changes to README are included in PR.

google-cla · 2021-07-02T15:35:07Z

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.

What to do if you already signed the CLA

Individual signers

It's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.

Corporate signers

Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoot (Public version).
The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.
The email used to register you as an authorized contributor must also be attached to your GitHub account.

ℹ️ Googlers: Go here for more info.

Nu11u5 · 2021-07-02T17:02:23Z

@googlebot I signed it!

google-cla · 2021-07-02T17:02:26Z

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

alex-galey · 2022-01-11T18:51:06Z

Is this interesting contribution blocked just because of a failed CLA detection by google bot ?!
@Nu11u5 can you try to sign with your github e-mail address nu***5@github.com ?

Nu11u5 · 2022-01-12T01:39:13Z

Is this interesting contribution blocked just because of a failed CLA detection by google bot ?! @Nu11u5 can you try to sign with your github e-mail address nu***5@github.com ?

I think I submitted my commit wrong, instead of using @users.noreply.github.com, so GitHub can't associate it with my account. Attempting to fix.

@alex-galey - fixed, thanks for pinging me the reminder.

# Conflicts: # package-lock.json # package.json

Nu11u5 · 2022-01-12T19:20:01Z

Recommited with merge conflicts properly resolved. Added syntax error output formatting so that file names and line numbers can be parsed by popular IDEs and linked to the source file. Tested in VS Code.

alex-galey · 2022-01-14T14:53:51Z

Is your PR also aims to solve that behavior of clasp not throwing an error when a Gaxios error happens and concluding with a misleading message "Pushed x files." when it didn't successfully push ?

Nu11u5 · 2022-01-15T01:16:23Z

Is your PR also aims to solve that behavior of clasp not throwing an error when a Gaxios error happens and concluding with a misleading message "Pushed x files." when it didn't successfully push ?

Yes, the success message and file list will now only be output when the push succeeds.

If it fails due to a syntax error detected by GAS, it will return a single line error message that can be automatically linked to the source file/line in an IDE like VS Code.

Any other type of error from GAS will return just the error description instead of dumping everything to the terminal.

alex-galey · 2022-01-21T19:08:43Z

@PopGoesTheWza is there a chance this PR is merged or do you see anything else that should be worked on ?

alex-galey · 2023-03-20T17:18:37Z

Hi @sqrrrl, is there a chance this PR is merged or do you see anything else that should be worked on ?

Nu11u5 · 2023-03-21T04:27:33Z

@alex-galey thanks for trying to bring attention to this. I had honestly forgotten about this PR. Please share of any additional work should be done.

alex-galey · 2023-08-22T19:39:54Z

@sqrrrl do you have any insight why this PR is not being merged ?

tecsoc · 2023-10-15T03:28:32Z

I need this PR for me too.
Why not merge?

* Fix typo in README: "They" -> "The" (google#975) * Add config-files and esmodules to docs/README (google#986) * Improve output (and suppress GaxiosError) on failed push (google#857) * fix run.md for Google Workspace user (google#898) * chore(deps-dev): bump @babel/traverse from 7.14.2 to 7.23.2 (google#982) Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * chore(deps): bump nanoid and mocha (google#977) Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * chore(deps): bump minimatch, recursive-readdir and mocha (google#976) Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * chore(deps-dev): bump word-wrap from 1.2.3 to 1.2.4 (google#970) Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * chore(deps): bump semver from 5.7.1 to 5.7.2 (google#969) Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * chore(deps): bump json-schema and jsprim (google#943) Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * chore(deps): bump node-forge and google-p12-pem (google#941) Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * chore(deps): bump qs from 6.5.2 to 6.5.3 (google#951) Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * chore(deps): bump json5 from 2.2.0 to 2.2.3 (google#954) Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * chore(deps): bump http-cache-semantics from 4.1.0 to 4.1.1 (google#958) Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * [docs] Add clasp run instructions to deploy script as API Executable (google#1004) * Fix typo (google#1002) * update install command for `@types/google-apps-script` (google#999) * rebuild --------- Co-authored-by: Adam Smith <927886+burkybang@users.noreply.github.com> Co-authored-by: Ravi van Rooijen <ravivanrooijen@live.nl> Co-authored-by: Nu11u5 <Nu11u5@users.noreply.github.com> Co-authored-by: Hirokazu Takatama <takatama@users.noreply.github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Dan Dascalescu <ddascalescu+github@gmail.com> Co-authored-by: Alejandro Marco <78371908+amalej@users.noreply.github.com> Co-authored-by: Joseph Mearman <joseph@mearman.co.uk>

andyconlin · 2024-10-25T01:25:59Z

I'm not experienced with package publishing, auto-versioning, etc. How do we go about prompting the release bot to create another release? Is that something that an admin has to initiate @PopGoesTheWza @sqrrrl?

google-cla bot added the cla: no label Jul 2, 2021

Nu11u5 force-pushed the add-GaxiosError-object-suppression branch from 05b32e6 to 81b498a Compare January 12, 2022 03:09

google-cla bot added cla: yes and removed cla: no labels Jan 12, 2022

Nu11u5 added 2 commits January 12, 2022 12:19

Suppress GaxiosError object dump on failed push

a7cecbd

Merge branch 'master' into add-GaxiosError-object-suppression

7b6a290

# Conflicts: # package-lock.json # package.json

Nu11u5 force-pushed the add-GaxiosError-object-suppression branch 2 times, most recently from f1a968b to 0d034da Compare January 12, 2022 19:17

Syntax error output file path and line number are IDE-parsable

33ab685

Nu11u5 force-pushed the add-GaxiosError-object-suppression branch from 0d034da to 33ab685 Compare January 12, 2022 22:51

Nu11u5 mentioned this pull request Feb 7, 2022

clasp push fails due to spurious syntax errors that can't be investigated #907

Closed

Nu11u5 added 3 commits February 7, 2022 22:12

Correctly check filename in returned syntax error

dc8e0e8

Format push errors with chalk

0c86301

Include check for local file extension from dotfile

abcadd4

Nu11u5 changed the title ~~Suppress GaxiosError object dump on failed push~~ Improve output (and suppress GaxiosError) on failed push Feb 10, 2022

Output formatted code snippet of the error

0b66274

Nu11u5 force-pushed the add-GaxiosError-object-suppression branch from 450175b to 0b66274 Compare February 15, 2022 14:20

alex-galey mentioned this pull request Oct 23, 2022

Deployment errors should show a failed deployment in Github Actions daikikatsuragawa/clasp-action#7

Open

PopGoesTheWza merged commit 1931c5f into google:master Dec 27, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Improve output (and suppress GaxiosError) on failed push #857

Improve output (and suppress GaxiosError) on failed push #857

Nu11u5 commented Jul 2, 2021 •

edited

Loading

google-cla bot commented Jul 2, 2021

Nu11u5 commented Jul 2, 2021

google-cla bot commented Jul 2, 2021

alex-galey commented Jan 11, 2022

Nu11u5 commented Jan 12, 2022 •

edited

Loading

Nu11u5 commented Jan 12, 2022

alex-galey commented Jan 14, 2022

Nu11u5 commented Jan 15, 2022 •

edited

Loading

alex-galey commented Jan 21, 2022

alex-galey commented Mar 20, 2023

Nu11u5 commented Mar 21, 2023

alex-galey commented Aug 22, 2023

tecsoc commented Oct 15, 2023

andyconlin commented Oct 25, 2024

Improve output (and suppress GaxiosError) on failed push #857

Improve output (and suppress GaxiosError) on failed push #857

Conversation

Nu11u5 commented Jul 2, 2021 • edited Loading

Fixes #827, #907

Checklist

google-cla bot commented Jul 2, 2021

What to do if you already signed the CLA

Individual signers

Corporate signers

Nu11u5 commented Jul 2, 2021

google-cla bot commented Jul 2, 2021

alex-galey commented Jan 11, 2022

Nu11u5 commented Jan 12, 2022 • edited Loading

Nu11u5 commented Jan 12, 2022

alex-galey commented Jan 14, 2022

Nu11u5 commented Jan 15, 2022 • edited Loading

alex-galey commented Jan 21, 2022

alex-galey commented Mar 20, 2023

Nu11u5 commented Mar 21, 2023

alex-galey commented Aug 22, 2023

tecsoc commented Oct 15, 2023

andyconlin commented Oct 25, 2024

Nu11u5 commented Jul 2, 2021 •

edited

Loading

Nu11u5 commented Jan 12, 2022 •

edited

Loading

Nu11u5 commented Jan 15, 2022 •

edited

Loading