Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Manually run the Build CI as part of the release #286

Merged
merged 1 commit into from
Mar 29, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ name: Build CI
on:
push:
branches: [ master ]
workflow_call: {}
workflow_dispatch: {}
pull_request:
branches: [ master ]
schedule:
Expand Down
4 changes: 0 additions & 4 deletions .github/workflows/release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,3 @@ jobs:
-H 'Authorization: token ${{ secrets.GITHUB_TOKEN }}' \
https://api.github.com/repos/google/closure-compiler-npm/releases \
-d '{"tag_name":"v${{ github.event.inputs.COMPILER_VERSION_NUMBER }}.0.0","name":"${{ github.event.inputs.COMPILER_VERSION_NUMBER }}.0.0","body":"Closure-compiler ${{ github.event.inputs.COMPILER_VERSION_NUMBER }} release","draft":false,"prerelease":false,"generate_release_notes":true}'
trigger-publication:
name: Trigger Build and Publish
needs: create-release
uses: google/closure-compiler-npm/.github/workflows/build.yml@master
3 changes: 2 additions & 1 deletion deployments.md
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,8 @@
1. Run the [Compiler release workflow](https://github.com/google/closure-compiler-npm/actions/workflows/release.yml)
* For the `COMPILER_VERSION_NUMBER` input, use the actual version number here without the `v`.
2. Verify the workflow runs successfully. It will push the release commit and tag.
3. Verify the Build CI workflow triggered from the commit builds and publishes the release successfully.
3. Manually run the [Compiler Build CI workflow](https://github.com/google/closure-compiler-npm/actions/workflows/build.yml)
4. Verify the new version published to npm.

## Deploying changes to the package CLIs or plugins

Expand Down