Treat any type annotation with a / character as a module reference
#2145
+5
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
I'm importing & testing this PR now. |
Contributor
|
@ChadKillingsworth |
Collaborator
Author
|
@brad4d Tests would be dependent on the other PRs. We can sit on this until then if you wish. Or I can add tests as a separate pr after everything lands. Mainly I needed this functionality on my code base. |
Contributor
|
@ChadKillingsworth |
Contributor
|
This has been submitted internally. |
alexeykomov
pushed a commit
to alexeykomov/closure-compiler
that referenced
this pull request
Feb 8, 2017
Closes google#2145 ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=139217972
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goes along (but does not require) #2094 and #2130.
When updating type node annotations during module rewriting, treat any type name with a
/as a module identifier. Needed for named modules loaded from a registry.Example
/** @type {!page/index.Context} */