Skip to content
This repository has been archived by the owner on Feb 23, 2022. It is now read-only.

Add Customized Splitter instead of hard code character '-' #76

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

SimonCat1989
Copy link

Add one more option "--css-class-splitter" when we use closure-stylesheets. By this developers can assign any single character as splitter for closure-stylesheets to use.

…heets. By this developers can assign any single character as splitter for closure-stylesheets to use.
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

@iflan
Copy link
Member

iflan commented Feb 26, 2016

Hi there,

Thanks for sending this patch. I've taken an initial look at it and I've got a few questions.

First, what's the motivation for this change? What situation do you have where you want to pick a custom splitter character? Looking at your comment on ClosureCommandLineCompiler.java, you require the user to use a --rename mode of either CLOSURE or DEBUG. If you use CLOSURE, you'd also have to change how the Closure JS Compiler does CSS class renaming. If you use DEBUG, I'm not really sure what the value is. So, if you could give me an example, it would make things a lot clearer.

Second, if we go down this path of allowing configurable splitters, would we want to allow choosing of renaming maps in general? This is possible today by passing the right classes to JobDescriptionBuilder through code, but not on the commandline. What do you think? Would that be useful?

Thanks,

Ian

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants