Allow configuring default corpora bucket location. #4479
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
letitz
changed the title
letitz
changed the title
letitz
requested review from
alhijazi and
paulsemel
and removed request for
alhijazi
paulsemel
approved these changes
Dec 13, 2024
jonathanmetzman
approved these changes
Dec 17, 2024
jonathanmetzman
pushed a commit
that referenced
this pull request
Dec 20, 2024
Allow instances to specify the GCS bucket location for data bundle buckets in `project.yaml` as a new key: `data_bundle_bucket_location`. This will allow creating regional buckets instead of using the default `US` multi-region which results in high data transfer costs in Chrome's instance.
jonathanmetzman
added a commit
that referenced
this pull request
Dec 26, 2024
Allow instances to specify the GCS bucket location for data bundle buckets in `project.yaml` as a new key: `data_bundle_bucket_location`. This will allow creating regional buckets instead of using the default `US` multi-region which results in high data transfer costs in Chrome's instance. Cherry pick of: #4479 Co-authored-by: Titouan Rigoudy <titouan@chromium.org>
jonathanmetzman
pushed a commit
that referenced
this pull request
Jan 8, 2025
Allow instances to specify the GCS bucket location for data bundle buckets in `project.yaml` as a new key: `data_bundle_bucket_location`. This will allow creating regional buckets instead of using the default `US` multi-region which results in high data transfer costs in Chrome's instance.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow instances to specify the GCS bucket location for data bundle buckets in
project.yamlas a new key:data_bundle_bucket_location.This will allow creating regional buckets instead of using the default
USmulti-region which results in high data transfer costs in Chrome's instance.