Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify get_fastboot_path() to allow for custom binaries #4518

Merged
merged 1 commit into from
Dec 18, 2024

Conversation

marktefftech
Copy link
Collaborator

Custom binaries are often used emulators (i.e. the binary being used by the host).

This code follows the same strategy used for the ADB binary above in get_adb_path().

Copy link
Collaborator

@jonathanmetzman jonathanmetzman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jonathanmetzman jonathanmetzman merged commit c207151 into google:master Dec 18, 2024
7 checks passed
jonathanmetzman pushed a commit that referenced this pull request Dec 20, 2024
Custom binaries are often used emulators (i.e. the binary being used by
the host).

This code follows the same strategy used for the ADB binary above in
`get_adb_path()`.
jonathanmetzman added a commit that referenced this pull request Dec 26, 2024
Custom binaries are often used emulators (i.e. the binary being used by
the host).

This code follows the same strategy used for the ADB binary above in
`get_adb_path()`.

Cherry pick: #4518

Co-authored-by: Mark Teffeteller <mteffeteller@google.com>
jonathanmetzman pushed a commit that referenced this pull request Jan 8, 2025
Custom binaries are often used emulators (i.e. the binary being used by
the host).

This code follows the same strategy used for the ADB binary above in
`get_adb_path()`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants