-
Notifications
You must be signed in to change notification settings - Fork 565
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update issue type and component for VRP uploaded bugs #4580
base: master
Are you sure you want to change the base?
Conversation
@@ -1056,6 +1059,19 @@ def update_component_labels_and_id(policy, testcase, issue): | |||
component_id = _get_predator_result_item(testcase, | |||
'suspected_buganizer_component_id') | |||
|
|||
# These bugs were filed via the direct upload and hence specific to the | |||
# google issue tracker. | |||
if hasattr(issue, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
when would it not have component_id?
You can replace this with getattr(issue, 'component_id', None) == VRP_UPLOAD_COMPONENT_ID.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i believe an issue wouldnt have component_id for non google issue tracker (monorail, jira)
but ooh thank you done!
43609e4
to
00584fb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
first of all, sorry i am like in and out here - its probably super annoying for you to review to try to remember what i was trying to do. i am going to finish this finally though - finally prioritized
@@ -1056,6 +1059,19 @@ def update_component_labels_and_id(policy, testcase, issue): | |||
component_id = _get_predator_result_item(testcase, | |||
'suspected_buganizer_component_id') | |||
|
|||
# These bugs were filed via the direct upload and hence specific to the | |||
# google issue tracker. | |||
if hasattr(issue, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i believe an issue wouldnt have component_id for non google issue tracker (monorail, jira)
but ooh thank you done!
Question 0: dont review this yet im running tests just to make sure its right
Question 1: i imagine there is a better place to put the component ids, but i havent been able to find it. where is it??