[Centipede] Implement corpus prune for centipede on corpus prune task #4707
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
javanlacerda
force-pushed
the
javan.prune-cent
branch
from
427ad2e to
f94468c
Compare
javanlacerda
changed the title
alhijazi
reviewed
Feb 27, 2025
src/clusterfuzz/_internal/tests/core/bot/fuzzers/centipede/centipede_engine_test.py
Show resolved
Hide resolved
alhijazi
reviewed
Feb 27, 2025
alhijazi
reviewed
Feb 27, 2025
src/clusterfuzz/_internal/bot/tasks/utasks/corpus_pruning_task.py
Outdated
Show resolved
Hide resolved
alhijazi
reviewed
Feb 27, 2025
src/clusterfuzz/_internal/bot/tasks/utasks/corpus_pruning_task.py
Outdated
Show resolved
Hide resolved
|
Seems that you have some formatting/linting errors, let's try to get the basic tests running |
javanlacerda
force-pushed
the
javan.prune-cent
branch
from
8bbd8d7 to
a64a86e
Compare
alhijazi
reviewed
Feb 28, 2025
.style.yapf
Outdated
| @@ -1,5 +1,5 @@ | |||
| [style] | |||
| based_on_style = chromium | |||
| based_on_style = google | |||
There was a problem hiding this comment.
Changing the style here makes it harder to review since many changes are just formatting. Maybe we can keep this to a follow-up PR
There was a problem hiding this comment.
Totally agree! but the basic tests will fail without it. If we're ok for merging with this, I can move this bump to another PR
There was a problem hiding this comment.
Addressed here #4710
javanlacerda
force-pushed
the
javan.prune-cent
branch
from
2556681 to
a64a86e
Compare
Closed
This change call's centipede's minimize_corpus method on each fuzzing round. This allows us to distill the corpus and only add useful units. On a local run, this allowed to decrease the number of units added from 2000+ to 5 with the same coverage. The cl also extracts some common functionality into engine_common.
Signed-off-by: Javan Lacerda <javanlacerda@google.com>
Signed-off-by: Javan Lacerda <javanlacerda@google.com>
Signed-off-by: Javan Lacerda <javanlacerda@google.com>
Signed-off-by: Javan Lacerda <javanlacerda@google.com>
Signed-off-by: Javan Lacerda <javanlacerda@google.com>
Signed-off-by: Javan Lacerda <javanlacerda@google.com>
Signed-off-by: Javan Lacerda <javanlacerda@google.com>
Signed-off-by: Javan Lacerda <javanlacerda@google.com>
Signed-off-by: Javan Lacerda <javanlacerda@google.com>
|
@jonathanmetzman @alhijazi I just removed the match case usage for simplicity and avoid any other frictions for now. |
alhijazi
approved these changes
Mar 7, 2025
javanlacerda
force-pushed
the
javan.prune-cent
branch
from
f196558 to
d2c0a9d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It implements corpus pruning for centipede fuzzer.