Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip 'rsync_from_disk()' call if the quarantine corpus is empty #4720

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

dhavalts1989
Copy link

We noticed an increase in fuzzers failing in the Coverage Client Job. We observed that the major cause was a failure during corpus pruning. Calling 'rsync_from_disk()' with an empty quarantine corpus leads to trigger unintended assertion in the corpus pruning job, which subsequently causes the Coverage Client Job to fail. To address this, we now skip the 'rsync_from_disk()' call if the quarantine corpus is empty, preventing unnecessary failures.

Copy link

google-cla bot commented Mar 10, 2025

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@harishdm harishdm force-pushed the fix_corpus_pruning branch from d8ae85d to 8926531 Compare March 11, 2025 02:39
@svasudevprasad
Copy link
Collaborator

/gcbrun

Copy link
Collaborator

@jonathanmetzman jonathanmetzman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@github-advanced-security
Copy link

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

@svasudevprasad
Copy link
Collaborator

/gcbrun

@marktefftech
Copy link
Collaborator

Can you please add a testcase to src/clusterfuzz/_internal/tests/core/bot/tasks/utasks/corpus_pruning_task_test.py to account for this new logic?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants