-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
There doesn't seem to be a way to exclude corpora from artifacts #84
Comments
I'm not sure why corpora are included in those artifacts in the first place. I think it would probably make sense to always remove all the "*_seed_corpus.zip" files before uploading them. |
The idea behind this action is to make it possible to compare the latest fuzz targets with PRs to figure out whether bugs are really reproducible in PRs only. Since forks (including systemd-stable) are usually based on the upstream repository where almost all the bugs are fixed before releases are cut it should be safe to assume that if CFLite finds bugs in PRs they are most likely introduced in those PRs. It should probably be brought back once google/clusterfuzzlite#84 is fixed.
The idea behind this action is to make it possible to compare the latest fuzz targets with PRs to figure out whether bugs are really reproducible in PRs only. Since forks (including systemd-stable) are usually based on the upstream repository where almost all the bugs are fixed before releases are cut it should be safe to assume that if CFLite finds bugs in PRs they are most likely introduced in those PRs. It should probably be brought back once google/clusterfuzzlite#84 is fixed.
How much does this matter to you? I don't want to add too many smart features like this since it will add too much complexity |
Those corpora take up about 400Mb (when they are compressed) and that's just too much I think. I can't upload huge artifacts like that on every commit (given that they are kept for 3 months by default). |
I'm going to try to fix this retention policy issue. |
@jonathanmetzman on second thought given that the size of those corpora can be controlled by scripts running on PRs I don't think they should be even uploaded. It took some time and I kind of DOSed myself with the public OSS-Fuzz corpora accidentally but it's possible to just open a PR, replace "code_change" with "batch" and put giant files in "$OUT/" to somewhat speed up this process. I still have no idea why GitHub allows that with read-only tokens but it is what it is apparently. |
I think we can accomplish what you are asking for by allowing you to set FILESTORE=no_filestore (should be an easy fix) and by using #93 |
From google/oss-fuzz#7186 (comment)
I think CFLite should pass
UPLOAD_BUILD
tobuild_fuzzers
to make it possible to exclude those large corpora from artifacts. Without that environment variable I can't skip that step with something likeThe text was updated successfully, but these errors were encountered: