Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change shebang to sh instead of bash #27

Merged
merged 1 commit into from
Feb 9, 2024

Conversation

krystof-k
Copy link
Contributor

@krystof-k krystof-k commented Feb 6, 2024

This PR changes the shebang in the autogen.sh from bash to sh, as using bash can cause troubles on systems without bash (like Alpine). I'm also using the #!/usr/bin/env sh syntax to use the user configured default shell instead of the hardcoded /bin/sh path.

It should cause no issues as there is not anything bash-specific in the autogen.sh source.

Related to #22.

Copy link

google-cla bot commented Feb 6, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@JinsukKim JinsukKim merged commit 9f8e8f5 into google:master Feb 9, 2024
1 check passed
@krystof-k krystof-k deleted the change-shebang branch February 11, 2024 21:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants