Skip to content

Commit

Permalink
Fix Markdown in build-rules.md (#1530)
Browse files Browse the repository at this point in the history
The mixing of HTML and Markdown breaks our translation pipeline: we see
the HTML and fail to parse things correctly.

This might be google/mdbook-i18n-helpers#97,
but I'm not 100% sure.

The fix is to make put the HTML on its own line: then the Markdown is
parsed again inside.

Fixes #1527.
  • Loading branch information
mgeisler authored Nov 30, 2023
1 parent 1ba88ba commit 97e1302
Showing 1 changed file with 2 additions and 0 deletions.
2 changes: 2 additions & 0 deletions src/chromium/build-rules.md
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@ You can also add `deps` on other Rust targets. Later we'll use this to
depend upon third party code.

<details>

You must specify _both_ the crate root, _and_ a full list of sources.
The `crate_root` is the file given to the Rust compiler representing the root
file of the compilation unit --- typically `lib.rs`. `sources` is a complete
Expand All @@ -33,6 +34,7 @@ Students might be wondering why we need a gn template, rather than using
[gn's built-in support for Rust static libraries][0].
The answer is that this template provides support for cxx interop, Rust features,
and unit tests, some of which we'll use later.

</details>

[0]: https://gn.googlesource.com/gn/+/main/docs/reference.md#func_static_library

0 comments on commit 97e1302

Please sign in to comment.