Skip to content

da: refresh translation #1203

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 26, 2023
Merged

da: refresh translation #1203

merged 2 commits into from
Sep 26, 2023

Conversation

mgeisler
Copy link
Contributor

Stats before:

312 translated messages, 2155 untranslated messages.

and after:

320 translated messages, 2136 untranslated messages.

Part of #286.

@mgeisler
Copy link
Contributor Author

Hey @thedataking, just a small refresh to get the latest strings into the PO file.

Stats before:

    312 translated messages, 2155 untranslated messages.

and after:

    320 translated messages, 2136 untranslated messages.

Part of #286.
Comment on lines -4040 to -4054
#: src/memory-management/stack.md:12
msgid ""
"```bob\n"
" Stack Heap\n"
".- - - - - - - - - - - - - -. .- - - - - - - - - - - - - - - -.\n"
": : : :\n"
": s1 : : :\n"
": +-----------+-------+ : : +----+----+----+----+----+ :\n"
": | ptr | o---+---+-----+-->| H | e | l | l | o | :\n"
": | len | 5 | : : +----+----+----+----+----+ :\n"
": | capacity | 5 | : : :\n"
": +-----------+-------+ : : :\n"
": : `- - - - - - - - - - - - - - - -'\n"
"`- - - - - - - - - - - - - -'\n"
"```"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @dyoo, this shows a (minor) problem with the skipping logic: we skip the ASCII art drawing because it doesn't contain " or //. So the logic should probably be made conditional on the programming language of the code block.

Copy link
Collaborator

@thedataking thedataking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

I reviewed the Danish translations in the top and scrolled through the rest to see if there were any more. Since the diff is so large, it is possible I missed some. It would be easier to review if the manual changes were a separate commit from the larger automated change but I'm not suggesting you change your workflow as we can always fix any papercuts in a separate commit.

@mgeisler
Copy link
Contributor Author

Since the diff is so large, it is possible I missed some. It would be easier to review if the manual changes were a separate commit from the larger automated change but I'm not suggesting you change your workflow as we can always fix any papercuts in a separate commit.

Yeah, this continues to be a problem... I'm thinking #1205 could help here to cleanly separate msgmerge from fixing fuzzy entries.

@mgeisler mgeisler enabled auto-merge (squash) September 26, 2023 09:17
@mgeisler mgeisler merged commit ea44e25 into main Sep 26, 2023
@mgeisler mgeisler deleted the refresh-da branch September 26, 2023 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants