-
Notifications
You must be signed in to change notification settings - Fork 1.8k
da: refresh translation #1203
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
da: refresh translation #1203
Conversation
Hey @thedataking, just a small refresh to get the latest strings into the PO file. |
Stats before: 312 translated messages, 2155 untranslated messages. and after: 320 translated messages, 2136 untranslated messages. Part of #286.
0388654
to
128ff7a
Compare
#: src/memory-management/stack.md:12 | ||
msgid "" | ||
"```bob\n" | ||
" Stack Heap\n" | ||
".- - - - - - - - - - - - - -. .- - - - - - - - - - - - - - - -.\n" | ||
": : : :\n" | ||
": s1 : : :\n" | ||
": +-----------+-------+ : : +----+----+----+----+----+ :\n" | ||
": | ptr | o---+---+-----+-->| H | e | l | l | o | :\n" | ||
": | len | 5 | : : +----+----+----+----+----+ :\n" | ||
": | capacity | 5 | : : :\n" | ||
": +-----------+-------+ : : :\n" | ||
": : `- - - - - - - - - - - - - - - -'\n" | ||
"`- - - - - - - - - - - - - -'\n" | ||
"```" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @dyoo, this shows a (minor) problem with the skipping logic: we skip the ASCII art drawing because it doesn't contain "
or //
. So the logic should probably be made conditional on the programming language of the code block.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
I reviewed the Danish translations in the top and scrolled through the rest to see if there were any more. Since the diff is so large, it is possible I missed some. It would be easier to review if the manual changes were a separate commit from the larger automated change but I'm not suggesting you change your workflow as we can always fix any papercuts in a separate commit.
Yeah, this continues to be a problem... I'm thinking #1205 could help here to cleanly separate |
Stats before:
and after:
Part of #286.