Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

uk: Cleaning up Ukrainian cloud-translate translations (day 1) #1494

Merged
merged 1 commit into from
Nov 30, 2023

Conversation

reta
Copy link
Contributor

@reta reta commented Nov 22, 2023

uk: Cleaning up Ukrainian cloud-translate translations (day 1)

@reta reta force-pushed the issue-836.day.1 branch 12 times, most recently from da86179 to 20213f1 Compare November 29, 2023 02:56
Signed-off-by: Andriy Redko <drreta@gmail.com>
@mgeisler
Copy link
Collaborator

Hi @reta, I would advice against putting too much into a single PR 😄 Better make it a non-draft PR now so you can get some feedback and quickly merge it!

@reta
Copy link
Contributor Author

reta commented Nov 30, 2023

Hi @reta, I would advice against putting too much into a single PR 😄 Better make it a non-draft PR now so you can get some feedback and quickly merge it!

@mgeisler I am totally agree with you, I was hoping to finish Day 1 in scope of this pull request but it is indeed is making pull request large, opening it up for review, thank you one more time for guiding me through.

@reta reta marked this pull request as ready for review November 30, 2023 14:15
@reta reta requested a review from dyeroshenko as a code owner November 30, 2023 14:15
@dyeroshenko
Copy link
Collaborator

LGTM!

@dyeroshenko dyeroshenko merged commit dc92a2b into google:main Nov 30, 2023
32 checks passed
@mgeisler
Copy link
Collaborator

Bam, amazing speed here! Thanks @dyeroshenko.

Now that #1073 has been merged, I would suggest doing a full refresh next: the strings should be quite stable now for the next many months.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants