Improved support for commenting when course timings change. #1797
Conversation
This * Works with the GitHub permissions model (at least in local testing on another temporary repo) * Only comments when the timings actually change
| mkdir -p ./course-schedule | ||
| cargo run -p mdbook-course --bin course-schedule > upstream-schedule | ||
|
|
||
| - name: "Download artifact from PR workflow" |
There was a problem hiding this comment.
Nit: I think this can be simplified by using download-artifact action. When I was implementing my workflow, I wasn't aware of this.
There was a problem hiding this comment.
I'll give it a try! The linked article seemed to say that wouldn't work, but on a closer reading maybe that's not true. Also, it's quite an old article so maybe it works now :)
There was a problem hiding this comment.
I haven't tried it, so it might indeed be not working :)
There was a problem hiding this comment.
Ah, it requires a PAT with read access to the source repository, and won't accept the repository input parameter without one -- even if that repository might be public.
There was a problem hiding this comment.
I am ok with not implementing it as well if it is not easy.
There was a problem hiding this comment.
(It's possible that the script I've used also won't work with a different, even public, repository -- we'll see!)
| await github.rest.issues.createComment({ | ||
| owner: context.repo.owner, | ||
| repo: context.repo.repo, | ||
| issue_number: context.payload.workflow_run.pull_requests[0].number, |
There was a problem hiding this comment.
This might be flaky as I discovered. In mdbook-i18n-helpers I fixed it by google/mdbook-i18n-helpers#168
According to my testing, the root cause of the issue is that context.payload.workflow_run.pull_requests array is not always populated. Some discussion on this issue https://github.com/orgs/community/discussions/25220
There was a problem hiding this comment.
Ugh, GH actions really are ugly. I wasn't able to test on a forked repository since I didn't have a place to fork from that would support running actions.
There was a problem hiding this comment.
Yes, debugging them is very cumbersome. It is possible to create a PR against your own fork though. That's what I did in my fork https://github.com/kdarkhan/mdbook-i18n-helpers/pulls?q=is%3Apr+is%3Aclosed
There was a problem hiding this comment.
Yeah, that's how I was testing -- but I think it doesn't accurately simulate the permissions of a cross-owner PR.
djmitche
requested review from
kdarkhan
and removed request for
mgeisler and
kdarkhan
|
I don't have approval permissions for this repo but LGTM. |
Let's fix this, I've invited you now! |
This