-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Execution: Add stderr block #2397
base: main
Are you sure you want to change the base?
Conversation
Hi @Alx-Lai, oh wow, this patch looks great! Thanks a lot for looking into this, I would very much like to have this feature implemented. I gave the PR a quick test run locally and this is how it looks: Screencast.from.2024-10-06.23-12-20.mp4This is nearly perfect. A few comments:
I looked briefly at the full Playground and discovered that they use a WebSocket now to stream the output line by line! They include markers to show if this is a I would be happy to merge this PR as a first step — I don't know how difficult it will be to adapt the |
Ok, I'll spend time looking into it. Thanks for the feedback! |
Add a stderr block. Pros: - we can make use of dbg macro in our code Cons: - there's a limitation that the compile message also shows To be improved: - compile message regex may change overtime - can use websocket to replace the current approach Applies patches from rust-lang/mdBook#1315 since the original change was not merged by rust-lang. Signed-off-by: Alx-Lai <alexabc722@gmail.com>
Updated the commit.
|
Hi @Alx-Lai, thanks for the update! I haven't forgotten about it, I'm just slow to review the change. I'll try asking internally if someone else can help review this. |
I just tested the updated version, and it works great! Screencast.from.2024-11-20.16-12-30.webm |
Add a stderr block.
Pros:
Applies patches from rust-lang/mdBook#1315 since the original change was not merged by rust-lang.
Issue: #531