Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing static_libs dep for libbirthday example #2640

Merged
merged 1 commit into from
Feb 26, 2025
Merged

Add missing static_libs dep for libbirthday example #2640

merged 1 commit into from
Feb 26, 2025

Conversation

randomPoison
Copy link
Collaborator

Turns out it's not enough to just depend on the bindgen module, we also need a direct static_libs dependency on the C module.

mgeisler
mgeisler approved these changes Feb 26, 2025
View reviewed changes
Copy link
Collaborator

@mgeisler mgeisler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alright, thanks for testing this!

@randomPoison randomPoison merged commit 4ee2337 into main Feb 26, 2025
37 checks passed
@randomPoison randomPoison deleted the legare/libbirthday-static-lib branch February 26, 2025 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mgeisler mgeisler mgeisler approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@randomPoison @mgeisler