-
Notifications
You must be signed in to change notification settings - Fork 2k
cargo: bump aarch64-rt from 0.3.1 to 0.4.2 in /src/bare-metal/aps/examples #3003
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cargo: bump aarch64-rt from 0.3.1 to 0.4.2 in /src/bare-metal/aps/examples #3003
Conversation
d392b27 to
8cec020
Compare
|
@qwandor I have pushed a commit to fix the build after this version bump. Could you review it? |
a77e7a0 to
53cbea6
Compare
Bumps [aarch64-rt](https://github.com/google/aarch64-rt) from 0.3.1 to 0.4.2. - [Release notes](https://github.com/google/aarch64-rt/releases) - [Changelog](https://github.com/google/aarch64-rt/blob/main/CHANGELOG.md) - [Commits](google/aarch64-rt@0.3.1...0.4.2) --- updated-dependencies: - dependency-name: aarch64-rt dependency-version: 0.4.2 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
| .balign 0x800 | ||
| vector_table_el1: | ||
| vector_table_el2: | ||
| vector_table_el3: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do you need vector_table_el2 or vector_table_el3? These examples are only intended for EL1.
| #![no_main] | ||
| #![no_std] | ||
|
|
||
| mod asm_exceptions; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The assembly files shouldn't be included here, main_rt should be using the exception vector provided by aarch64-rt instead.
| global_asm!(include_str!("exceptions.S")); | ||
| global_asm!(include_str!("idmap.S")); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why split this module up into three? All three assembly files should be used in all the examples that don't use aarch64-rt, and none of them should be used in the example that does.
53cbea6 to
656ac53
Compare
656ac53 to
4d1ac18
Compare
|
@qwandor Thank you for the fixes! The short answer to your review questions is that I was approaching the errors mechanically without a deep investigation of what the code is doing (this is why I added you to the review!) So, for example, I added |
…mples (google#3003) Bumps [aarch64-rt](https://github.com/google/aarch64-rt) from 0.3.1 to 0.4.2. --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Andrew Walbran <qwandor@google.com>
…mples (google#3003) Bumps [aarch64-rt](https://github.com/google/aarch64-rt) from 0.3.1 to 0.4.2. --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Andrew Walbran <qwandor@google.com>
Bumps aarch64-rt from 0.3.1 to 0.4.2.
Release notes
Sourced from aarch64-rt's releases.
Changelog
Sourced from aarch64-rt's changelog.
Commits
b04472fenable_mmu should be unsafe.b76d4caPrepare for 0.4.1 release.2b57b4fMerge pull request #36 from google/entry376a124Make enable_mmu public.8a24606Make set_exception_vector public.9866e64Prepare for 0.4.0 release.6176ec9Clean up imports and add to changelog.30b06d7Merge pull request #31 from m4tx/start_core_argbb3a41baddress review comments4786357fix the buildDependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)