Skip to content

Conversation

jzpin
Copy link
Contributor

@jzpin jzpin commented May 24, 2023

Start the translation of Chinese (Simplified). This is a freshly generated empty po file.

Part of #324.

Start the translation of Chinese (Simplified).
@google-cla
Copy link

google-cla bot commented May 24, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@jzpin
Copy link
Contributor Author

jzpin commented May 24, 2023

I have signed the CLA just now.

@mgeisler mgeisler changed the title Create zh-CN.po zh-Hans: Create zh-Hans.po May 25, 2023
@mgeisler
Copy link
Collaborator

Thanks for getting this started @jzpin!

Based on #324 (comment), can I get you to rename the file to zh-Hans.po?

@jzpin
Copy link
Contributor Author

jzpin commented May 25, 2023

Thanks for getting this started @jzpin!

Based on #324 (comment), can I get you to rename the file to zh-Hans.po?

Yes. Commit updated.

Use zh-Hans instead of zh-CN unless there are translations for different regions.
@mgeisler
Copy link
Collaborator

Excellent, thanks a lot! I'm excited to see this get started!

mgeisler added a commit to suetfei/comprehensive-rust that referenced this pull request May 25, 2023
mgeisler added a commit that referenced this pull request May 25, 2023
* Update CODEOWNERS to include zh-cn

* Update filename to follow #676

---------

Co-authored-by: Martin Geisler <martin@geisler.net>
@mgeisler mgeisler merged commit c3ac70b into google:main May 25, 2023
@jzpin jzpin deleted the zh_CN_translation branch May 29, 2023 23:52
NoahDragon pushed a commit to wnghl/comprehensive-rust that referenced this pull request Jul 19, 2023
* Update CODEOWNERS to include zh-cn

* Update filename to follow google#676

---------

Co-authored-by: Martin Geisler <martin@geisler.net>
NoahDragon pushed a commit to wnghl/comprehensive-rust that referenced this pull request Jul 19, 2023
* Create zh-CN.po

Start the translation of Chinese (Simplified).

* Create zh-Hans.po

Start the translation of Chinese (Simplified).

* Delete zh-CN.po

Use zh-Hans instead of zh-CN unless there are translations for different regions.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants