Skip to content

Commit

Permalink
Move c99 flag from BUILD file to bazel cmd line
Browse files Browse the repository at this point in the history
Requiring c99 for everyone breaks downstream users.
  • Loading branch information
gchatelet committed Sep 13, 2024
1 parent 747d711 commit c4970ff
Show file tree
Hide file tree
Showing 3 changed files with 37 additions and 9 deletions.
35 changes: 35 additions & 0 deletions .bazelrc
Original file line number Diff line number Diff line change
@@ -0,0 +1,35 @@
###############################################################################
# Common flags that apply to all configurations.
# Use sparingly for things common to all compilers and platforms.
###############################################################################

# Enable Bzlmod for every Bazel command
common --enable_bzlmod

# Prevent invalid caching if input files are modified during a build.
build --experimental_guard_against_concurrent_changes

###############################################################################
# Options for continuous integration.
###############################################################################

# Speedup bazel using a ramdisk.
build:ci --sandbox_base=/dev/shm

# Show as many errors as possible.
build:ci --keep_going

# Show subcommands when building
build:ci --subcommands=true

# Make sure we test for C99 compliance when building the library
build:ci --conlyopt=-std=c99

# Show test errors.
test:ci --test_output=errors

###############################################################################

# The user.bazelrc file is not checked in but available for local mods.
# Always keep this at the end of the file so that user flags override.
try-import %workspace%/user.bazelrc
1 change: 0 additions & 1 deletion BUILD.bazel
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,6 @@ exports_files(["LICENSE"])
INCLUDES = ["include"]

C99_FLAGS = [
"-std=c99",
"-Wall",
"-Wextra",
"-Wmissing-declarations",
Expand Down
10 changes: 2 additions & 8 deletions bazel/ci/docker/Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -25,13 +25,7 @@ COPY . .

FROM devel AS build
RUN bazel version
RUN bazel build \
-c opt \
--subcommands=true \
...
RUN bazel build --config=ci ...

FROM build AS test
RUN bazel test \
-c opt \
--test_output=errors \
...
RUN bazel test --config=ci ...

0 comments on commit c4970ff

Please sign in to comment.