Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cpuinfo_ppc.h includes internal header #151

Closed
zhsj opened this issue Dec 28, 2020 · 1 comment · Fixed by #164
Closed

cpuinfo_ppc.h includes internal header #151

zhsj opened this issue Dec 28, 2020 · 1 comment · Fixed by #164
Assignees
@Mizux
Labels
bug Something isn't working cmake CMake related issue
Milestone
v0.7.0

Comments

@zhsj
Copy link

zhsj commented Dec 28, 2020 •
edited by Mizux
Loading

cpu_features/include/cpuinfo_ppc.h

Line 20 in e2f6dea

#include "internal/hwcaps.h"

However this internal file is not installed by cmake.
@Mizux
Copy link
Collaborator

Mizux commented Dec 28, 2020

to add here if I'm not wrong

cpu_features/CMakeLists.txt

Lines 86 to 88 in e2f6dea

elseif(PROCESSOR_IS_POWER)
list(APPEND ${HDRS_LIST_NAME} ${PROJECT_SOURCE_DIR}/include/cpuinfo_ppc.h)
list(APPEND ${SRCS_LIST_NAME} ${PROJECT_SOURCE_DIR}/src/cpuinfo_ppc.c)

@Mizux Mizux self-assigned this Jun 11, 2021
@gchatelet gchatelet added bug Something isn't working cmake CMake related issue labels Jun 11, 2021
@gchatelet gchatelet added this to the v0.7.0 milestone Jun 11, 2021
@gchatelet gchatelet linked a pull request Jun 25, 2021 that will close this issue
Avoid leaking internal headers for ppc #164
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Mizux Mizux

Labels
bug Something isn't working cmake CMake related issue
Projects
None yet
Milestone
v0.7.0
Development

Successfully merging a pull request may close this issue.

Avoid leaking internal headers for ppc google/cpu_features
3 participants
@gchatelet @zhsj @Mizux