Avoid leaking internal headers for ppc #164
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gchatelet
changed the title
Mizux
reviewed
Jun 25, 2021
Mizux
reviewed
Jun 25, 2021
Mizux
requested changes
Jun 25, 2021
src/cpuinfo_ppc.c
Outdated
| @@ -130,23 +130,29 @@ PPCInfo GetPPCInfo(void) { | |||
| return info; | |||
| } | |||
|
|
|||
| PPCPlatformTypeStrings kEmptyPPCPlatformTypeStrings; | |||
|
|
|||
| PPCPlatformTypeStrings CpuFeatures_GetPlatformType(void) { | |||
There was a problem hiding this comment.
GetPPCPlatformTypeString() ?
like line 151: PPCPlatformStrings GetPPCPlatformStrings(void) {
Mizux
requested changes
Jun 26, 2021
There was a problem hiding this comment.
FYI: Need to fix test/cpuinfo_ppc_test.cc
FAILED: /usr/bin/c++ -DCPU_FEATURES_MOCK_FILESYSTEM -DCPU_FEATURES_TEST -DSTACK_LINE_READER_BUFFER_SIZE=1024 -I../../test/../include -isystem googletest-src/googletest/include -isystem googletest-src/googletest -isystem googletest-src/googlemock/include -isystem googletest-src/googlemock -g -std=c++11 -MMD -MT test/CMakeFiles/cpuinfo_ppc_test.dir/cpuinfo_ppc_test.cc.o -MF test/CMakeFiles/cpuinfo_ppc_test.dir/cpuinfo_ppc_test.cc.o.d -o test/CMakeFiles/cpuinfo_ppc_test.dir/cpuinfo_ppc_test.cc.o -c ../../test/cpuinfo_ppc_test.cc
313../../test/cpuinfo_ppc_test.cc: In member function ‘virtual void cpu_features::{anonymous}::CpustringsPPCTest_Blade_Test::TestBody()’:
314../../test/cpuinfo_ppc_test.cc:60:38: error: ‘SetPlatformTypes’ was not declared in this scope
315 SetPlatformTypes("power7", "power8");ref: https://travis-ci.org/github/google/cpu_features/jobs/774641309
ps: Again I would refactor it to SetPPCPlatformTypeString() ;)
Mizux
approved these changes
Jun 29, 2021
Mizux
approved these changes
Jun 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.