Fails on FreeBSD: error: "Unsupported fallback detection of SSE OS support."

[yurivict]

#error "Unsupported OS"
 ^
/wrkdirs/usr/ports/devel/volk/work/volk-2.5.0/cpu_features/src/cpuinfo_x86.c:1268:2: error: "Unsupported fallback detection of SSE OS support."
#error "Unsupported fallback detection of SSE OS support."
 ^
2 errors generated.

[Mizux]

cpu_features/src/cpuinfo_x86.c

Lines 1230 to 1274 in bc2846e

	static void DetectSseViaOs(X86Features* features) {
	#if defined(CPU_FEATURES_OS_WINDOWS)
	// https://docs.microsoft.com/en-us/windows/win32/api/processthreadsapi/nf-processthreadsapi-isprocessorfeaturepresent
	features->sse =
	GetWindowsIsProcessorFeaturePresent(PF_XMMI_INSTRUCTIONS_AVAILABLE);
	features->sse2 =
	GetWindowsIsProcessorFeaturePresent(PF_XMMI64_INSTRUCTIONS_AVAILABLE);
	features->sse3 =
	GetWindowsIsProcessorFeaturePresent(PF_SSE3_INSTRUCTIONS_AVAILABLE);
	#elif defined(CPU_FEATURES_OS_DARWIN)
	// Handling Darwin platform through sysctlbyname.
	features->sse = GetDarwinSysCtlByName("hw.optional.sse");
	features->sse2 = GetDarwinSysCtlByName("hw.optional.sse2");
	features->sse3 = GetDarwinSysCtlByName("hw.optional.sse3");
	features->ssse3 = GetDarwinSysCtlByName("hw.optional.supplementalsse3");
	features->sse4_1 = GetDarwinSysCtlByName("hw.optional.sse4_1");
	features->sse4_2 = GetDarwinSysCtlByName("hw.optional.sse4_2");
	#elif defined(CPU_FEATURES_OS_LINUX_OR_ANDROID)
	// Handling Linux platform through /proc/cpuinfo.
	const int fd = CpuFeatures_OpenFile("/proc/cpuinfo");
	if (fd >= 0) {
	StackLineReader reader;
	StackLineReader_Initialize(&reader, fd);
	for (;;) {
	const LineResult result = StackLineReader_NextLine(&reader);
	const StringView line = result.line;
	StringView key, value;
	if (CpuFeatures_StringView_GetAttributeKeyValue(line, &key, &value)) {
	if (CpuFeatures_StringView_IsEquals(key, str("flags"))) {
	features->sse = CpuFeatures_StringView_HasWord(value, "sse");
	features->sse2 = CpuFeatures_StringView_HasWord(value, "sse2");
	features->sse3 = CpuFeatures_StringView_HasWord(value, "sse3");
	features->ssse3 = CpuFeatures_StringView_HasWord(value, "ssse3");
	features->sse4_1 = CpuFeatures_StringView_HasWord(value, "sse4_1");
	features->sse4_2 = CpuFeatures_StringView_HasWord(value, "sse4_2");
	break;
	}
	}
	if (result.eof) break;
	}
	CpuFeatures_CloseFile(fd);
	}
	#else
	#error "Unsupported fallback detection of SSE OS support."
	#endif

@yurivict Do you know which functions/implementation we could use to support SSE detection on a FreeBSD OS ?

[Mizux]

First it means we must detect FreeBSD OS here

cpu_features/include/cpu_features_macros.h

Lines 70 to 85 in 3e8243b

	#if defined(__linux__)
	#define CPU_FEATURES_OS_LINUX_OR_ANDROID
	#endif
	#if defined(__ANDROID__)
	#define CPU_FEATURES_OS_ANDROID
	#endif
	#if (defined(_WIN64) || defined(_WIN32))
	#define CPU_FEATURES_OS_WINDOWS
	#endif
	#if (defined(__apple__) || defined(__APPLE__) || defined(__MACH__))
	#define CPU_FEATURES_OS_DARWIN
	#endif

note: https://docs.freebsd.org/en/books/porters-handbook/porting-dads/#porting-versions

[yurivict]

You can detect FreeBSD with

#if defined(__FreeBSD__)
#endif