Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New code layout for list_cpu_features #208

Closed

Conversation

toor1245
Copy link
Contributor

@toor1245 toor1245 commented Nov 19, 2021

This pull request is intended for architecture isolation and further OS implementation. @gchatelet, what do you think about it?

@toor1245 toor1245 marked this pull request as draft November 19, 2021 03:42
@toor1245 toor1245 force-pushed the new-code-layout-for-list-cpu-features branch from 02711c1 to 95d0915 Compare November 19, 2021 04:05
@toor1245 toor1245 force-pushed the new-code-layout-for-list-cpu-features branch from 95d0915 to d966c5a Compare November 19, 2021 04:09
@toor1245 toor1245 marked this pull request as ready for review November 19, 2021 04:15
@toor1245 toor1245 marked this pull request as draft December 2, 2021 01:08
@angusryer
Copy link

@gchatelet @toor1245 -- So it seems that the code layout changes referenced in #150 #186 #194 #204 #208 #209 #210 #211 (which mostly relate to supporting arm64) have been split between #194 (which was merged already) and this PR, is that correct?

And that the main PR for adding support for the M1 is #204, but it is too large for review, correct?

And finally, that the layout changes themselves seem to be the major blocker for the PRs related to supporting the M1 (most of the PRs listed above), is that also correct?

Forgive my ignorance if that's totally off--I'm just trying to understand the situation.

@toor1245
Copy link
Contributor Author

@angusryer, This PR is not related to #194, it's just a suggestion for the code health of list_cpu_features, and doesn't block M1 in any way, since list_cpu_features just uses the cpu_features API for demo

PR #150 is deprecated.
PR #186 aarch64 detection works via inline assembly for FreeBSD and Linux, for Windows and macOs I'm investigating for now.
PR #204 is based on #150 plus works with new code layout #194 and detects more cpu flags.

@angusryer
Copy link

Thanks @toor1245 for the clarification. I'll follow 186 and 204 more closely since these seem to be pointing toward a fix for the compile error I'm getting on my M1 for a package that has cpu_features as its dependency.

@toor1245 toor1245 closed this Jul 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants