Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added some missing amd uarch #259

Merged
merged 6 commits into from
Aug 4, 2022
Merged

Added some missing amd uarch #259

merged 6 commits into from
Aug 4, 2022

Conversation

DaniAffCH
Copy link
Contributor

@DaniAffCH DaniAffCH commented Jul 26, 2022

According to https://en.wikichip.org/wiki/amd/cpuid I added detection of the following AMD uarch:

  • Added family 0x18 model 0x00 to zen architecture
  • Moved family 0x17 model 0x18 from zen to zen plus architecture
  • Added family 0x15 model 0x10 to piledriver architecture
  • Created identifier for AMD_LLANO and added family 0x12 model 0x00 to it (Does it have to be merged with K12?)
    EDIT: merged with K12

@google-cla
Copy link

google-cla bot commented Jul 26, 2022

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@@ -667,6 +667,9 @@ X86Microarchitecture GetX86Microarchitecture(const X86Info* info) {
case CPUID(0x12, 0x01):
// https://www.amd.com/system/files/TechDocs/44739_12h_Rev_Gd.pdf
return AMD_K12;
case CPUID(0x12, 0x00):
// https://www.amd.com/system/files/TechDocs/44739_12h_Rev_Gd.pdf
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see LLANO by the link that you provided, so change it to https://en.wikichip.org/wiki/amd/cpuid, since there is a definition cpuid of LLANO

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No more needed as I removed LLANO identifier. It has been merged with K12

@gchatelet
Copy link
Collaborator

Thank you @DaniAffCH for the PR (and @toor1245 for the review)

@toor1245
Copy link
Contributor

toor1245 commented Aug 4, 2022

@DaniAffCH, I see the same case CPUID(0x15, 0x10) in #255, could you remove it?

@Mizux Mizux merged commit 426b036 into google:main Aug 4, 2022
@gchatelet gchatelet added this to the v0.8.0 milestone Apr 27, 2023
@gchatelet gchatelet added the enhancement New feature or request label Apr 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants