-
Notifications
You must be signed in to change notification settings - Fork 262
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added some missing amd uarch #259
Conversation
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
@@ -667,6 +667,9 @@ X86Microarchitecture GetX86Microarchitecture(const X86Info* info) { | |||
case CPUID(0x12, 0x01): | |||
// https://www.amd.com/system/files/TechDocs/44739_12h_Rev_Gd.pdf | |||
return AMD_K12; | |||
case CPUID(0x12, 0x00): | |||
// https://www.amd.com/system/files/TechDocs/44739_12h_Rev_Gd.pdf |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't see LLANO by the link that you provided, so change it to https://en.wikichip.org/wiki/amd/cpuid, since there is a definition cpuid of LLANO
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 this link will be cool:
https://en.wikichip.org/wiki/amd/cpuid#Family_18_.2812h.29
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No more needed as I removed LLANO identifier. It has been merged with K12
Thank you @DaniAffCH for the PR (and @toor1245 for the review) |
@DaniAffCH, I see the same case |
According to https://en.wikichip.org/wiki/amd/cpuid I added detection of the following AMD uarch:
Added family 0x18 model 0x00 to zen architectureMoved family 0x17 model 0x18 from zen to zen plus architectureAdded family 0x15 model 0x10 to piledriver architectureEDIT: merged with K12