-
Notifications
You must be signed in to change notification settings - Fork 262
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add CI MacOS Arm64 support #356
Conversation
a9834ac
to
2f11344
Compare
- name: Check cmake | ||
run: cmake --version | ||
- name: Configure | ||
run: cmake -S. -Bbuild -G "Xcode" -DCMAKE_CONFIGURATION_TYPES=Release -DCMAKE_INSTALL_PREFIX:PATH=destination |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added -DCMAKE_INSTALL_PREFIX:PATH=destination
to fix the following error for the latest macos version:
make[1]: Nothing to be done for `preinstall'.
Install the project...
/opt/homebrew/Cellar/cmake/3.30.2/bin/cmake -P cmake_install.cmake
CMake Error at cmake_install.cmake:41 (file):
-- Install configuration: "Release"
file cannot create directory: /usr/local/lib. Maybe need administrative
privileges.
@gchatelet, @Mizux, this PR is ready to review please take a look. |
@@ -0,0 +1,35 @@ | |||
name: AArch64 MacOS Bazel |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add this line on top ?
# ref: https://github.com/actions/runner-images
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
@@ -0,0 +1,43 @@ | |||
name: AArch64 MacOS CMake |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same here
# ref: https://github.com/actions/runner-images
Requested change: Context For OS we prefer to use macos (as now) following the github runner convention So could you rename file as |
ec9f4d8
to
1318965
Compare
Updated, should we rename |
jobs: | ||
# Building using the github runner environement directly. | ||
bazel: | ||
runs-on: macos-latest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add # Using M1 processors, ref: https://github.com/actions/runner-images
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
jobs: | ||
# Building using the github runner environement directly. | ||
xcode: | ||
runs-on: macos-latest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ditto
TLDR: Not yet. Context: I think we should split our CI matrix result in two tables:
Also to ease the work of @gchatelet to adapt his script to generate the badges, we are thinking to add a prefix |
1318965
to
2194fea
Compare
https://docs.github.com/en/actions/using-github-hosted-runners/using-github-hosted-runners/about-github-hosted-runners
Proof of success:
macos-arm64 cmake: https://github.com/toor1245/cpu_features/actions/runs/10551510281
We don't have mock compilation definitions for bazel, so our tests will get real CPU information and the tests will fail:
https://github.com/toor1245/cpu_features/actions/runs/10551510292/job/29229039421#step:6:23