Skip to content
This repository has been archived by the owner on Jun 27, 2023. It is now read-only.

Dependency updates #301

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Conversation

wjwoodson
Copy link

@wjwoodson wjwoodson commented Jun 4, 2022

This PR includes two three updates to resolve issues recently encountered when setting up a new debian:buster-image based installation:

  1. Latest Flask library is no longer compatible with Werkzeug<1.0.0 (at least since Flask 2.0.0). The changes here remove the Werkzeug version pin from requirements, and make a small update to use cachelib for functionality extracted to its own library (ref).
  2. Small change to migrate jinja2.Markup() usage to markupsafe.Markup() for similar library deprecations (ref).
  3. Updates the MySQL connection string in README to specify using the pymysql driver included in the requirements file (ref).

@google-cla
Copy link

google-cla bot commented Jun 4, 2022

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@wjwoodson wjwoodson changed the title Werkzeug updates Dependency updates Jun 4, 2022
@gwarf
Copy link

gwarf commented Oct 7, 2022

It's also required to update send in scoreboard/attachments/file.py as due to download_name replacing Flask's attachment_filename: https://github.com/pallets/werkzeug/blob/d36aaf12b5d12634844e4c7f5dab4a8282688e12/src/werkzeug/utils.py#L400

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants