Flip the default for explicitBindingConflictsWithInject to enabled.

RELNOTES=Flip the default for explicitBindingConflictsWithInject to enabled. PiperOrigin-RevId: 591064440
google · Dec 14, 2023 · 8372c63 · 8372c63
1 parent 13d64c6
commit 8372c63
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 4 deletions.
diff --git a/java/dagger/internal/codegen/compileroption/ProcessingEnvironmentCompilerOptions.java b/java/dagger/internal/codegen/compileroption/ProcessingEnvironmentCompilerOptions.java
@@ -404,7 +404,7 @@ public ImmutableList<String> aliases() {
      * How to report that an explicit binding in a subcomponent conflicts with an {@code @Inject}
      * constructor used in an ancestor component.
      */
-    EXPLICIT_BINDING_CONFLICTS_WITH_INJECT(WARNING, ERROR, NONE),
+    EXPLICIT_BINDING_CONFLICTS_WITH_INJECT(ERROR, WARNING, NONE),
     ;
 
     final ValidationType defaultType;

diff --git a/javatests/dagger/internal/codegen/DuplicateBindingsValidationTest.java b/javatests/dagger/internal/codegen/DuplicateBindingsValidationTest.java
@@ -1052,9 +1052,8 @@ public void childProvidesConflictsWithParentInjects() {
     CompilerTests.daggerCompiler(foo, injected1, injected2, provided1, provided2)
         .compile(
             subject -> {
-              subject.hasErrorCount(0);
-              subject.hasWarningCount(1);
-              subject.hasWarningContaining(
+              subject.hasErrorCount(1);
+              subject.hasErrorContaining(
                       message(
                           "Foo is bound multiple times:",
                           "    @Inject Foo(Set<String>) [Injected1]",