Skip to content

Commit

Permalink
Make dagger.internal.Provider extend jakarta.inject.Provider.
Browse files Browse the repository at this point in the history
Issue #2058.

RELNOTES=Add a jakarta.inject.Provider runtime dependency in preparation for supporting Jakarta Providers
PiperOrigin-RevId: 633750268
  • Loading branch information
Chang-Eric authored and Dagger Team committed May 17, 2024
1 parent f41033c commit 8d0a960
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 2 deletions.
2 changes: 2 additions & 0 deletions java/dagger/BUILD
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,7 @@ java_library(
exports = ["//third_party/java/jsr330_inject"],
deps = [
"//third_party/java/jsr330_inject",
"@maven//:jakarta_inject_jakarta_inject_api",
],
)

Expand All @@ -43,6 +44,7 @@ gen_maven_artifact(
artifact_name = "Dagger",
artifact_target = ":core",
artifact_target_maven_deps = [
"jakarta.inject:jakarta.inject-api",
"javax.inject:javax.inject",
],
javadoc_root_packages = ["dagger"],
Expand Down
3 changes: 1 addition & 2 deletions java/dagger/internal/Provider.java
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,5 @@
* Internal Provider interface to make support for {@code javax.inject.Provider} and
* {@code jakarta.inject.Provider} easier. Do not use outside of Dagger implementation code.
*/
// TODO(erichang): Make this also extend the Jakarta Provider
public interface Provider<T> extends javax.inject.Provider<T> {
public interface Provider<T> extends javax.inject.Provider<T>, jakarta.inject.Provider<T> {
}

0 comments on commit 8d0a960

Please sign in to comment.