-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Suppress annotation on @Inject is not honored on the Factory #4302
Comments
Thanks for letting us know. Unfortunately there isn't really a great way to decide when to copy this deprecation annotation over, as there isn't really a 1:1 correspondence since it isn't like we're copying a method or something. The deprecated usage in the constructor turns into needing to suppress it across the whole factory class. Presumably we'd also need to suppress it at the |
I have a class that needs to inject a deprecated class. It looks like this:
The generated
Foo_Factory
doesn't add the@SuppressWarning
for"deprecation"
:This prevents me to run java with
-Werror
active. I found that this feature exist on Hilt for other cases or at least that's what I understand from #2834.Something similar happens when the deprecated class has the
@Inject
. The Factory also contains warning. Example:I found out this last one while writing this snippets for this issue so I don't care that much about it. And I'm not sure if it should be tracked in this issue or open a new one.
The text was updated successfully, but these errors were encountered: