DO NOT SUBMIT: Proposal for fixing https://github.com/google/dagger/issues/1120 #1266
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/cc @oehme |
|
The android artifact has it's own processor I believe, should the same property be checked there as well? |
|
@evant yep you're right. I don't think that one needs to remain dynamic, I think it's much safer to just enable that one from the getgo |
oehme
approved these changes
Aug 29, 2018
| @@ -93,6 +93,10 @@ public SourceVersion getSupportedSourceVersion() { | |||
| options.addAll(CompilerOptions.SUPPORTED_OPTIONS); | |||
| options.addAll(spiPlugins.allSupportedOptions()); | |||
| options.addAll(validationPlugins.allSupportedOptions()); | |||
| if (Ascii.equalsIgnoreCase( | |||
| "enabled", System.getProperties().getProperty("dagger.gradle.incremental"))) { | |||
There was a problem hiding this comment.
As mentioned on the other thread, I think this could/should be an option, not a system property. Since init has already been called at this point, you already know all the options that were passed by the client.
|
Closing this - I've imported the change internally and once it's reviewed we'll do our regular syncs |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.