Skip to content

Fix two documentation bugs #40

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 21, 2020
Merged

Fix two documentation bugs #40

merged 1 commit into from
Feb 21, 2020

Conversation

srawlins
Copy link
Contributor

See two current markdown rendering issues:

  1. https://pub.dev/packages/cli_pkg#configuration
  2. https://github.com/google/dart_cli_pkg/blob/master/doc/npm.md

This fixes each. The first fix is unfortunate, as the markdown is valid, but there is a bug in the Dart markdown package: dart-lang/tools#1416.

@srawlins srawlins requested a review from nex3 February 21, 2020 16:06
nex3
nex3 approved these changes Feb 21, 2020
View reviewed changes
Copy link
Collaborator

@nex3 nex3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Sam!

@srawlins srawlins merged commit 4393860 into google:master Feb 21, 2020
@srawlins srawlins deleted the doc-bugs branch February 21, 2020 23:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nex3 nex3 nex3 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@srawlins @nex3