Update ib count #25
Closed
Update ib count #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- use the same funciton to generate union for both pm4 and reg - fix the case where both bitfield is used to extend bitset for a reg - use union/enum instead of uint32 for non-buildin types
- INDEX_SIZE is using type pc_di_index_size which needs 2 bits, the fix is following the definition of vgt_draw_initiator_a4xx
bjoeris
approved these changes
Oct 24, 2023
shanminchao
reviewed
Oct 25, 2023
| @@ -191,7 +191,7 @@ class EmulatePM4 | |||
| // Keep all emulation state together | |||
| struct EmulateState | |||
| { | |||
| static const uint32_t kMaxPendingIbs = 100; | |||
There was a problem hiding this comment.
Can you give context on this?
The reason it's 100 is because I didn't think set_draw_state ever exceeded 100 count. Are you saying that's possible?
If we're exceeding this # for a non-set-draw-state, then we could be dealing with a bug.
There was a problem hiding this comment.
replied in the chatroom, we can continue the discussion there. Benson has more info on the capture.
|
PR 32 fixes this issue properly. We can probably close this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
update the max ib count to 256