Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regression in offline search popover on v0.5.1 #1304

Closed
jmichelgarcia opened this issue Nov 3, 2022 · 5 comments · Fixed by #1305
Closed

Regression in offline search popover on v0.5.1 #1304

jmichelgarcia opened this issue Nov 3, 2022 · 5 comments · Fixed by #1305

Comments

@jmichelgarcia
Copy link

jmichelgarcia commented Nov 3, 2022

v.0.5.1
search-hugo

v0.4.1-0.20220713143414-1b10f6bebef9
hugo-v0 4

config.toml

[params]
offlineSearch = true
offlineSearchSummaryLength = 200
offlineSearchMaxResults = 25
sidebar_search_disable = false

Source
https://github.com/jmichelgarcia/docsy-algolia

To reproduce

  1. Go to https://sensational-chebakia-db2125.netlify.app/
  2. Type Test in the search
  3. Scroll down
@jmichelgarcia
Copy link
Author

Between the two screenshots, there is no change beyond the below:

➜  my-new-site git:(main) hugo mod get -u github.com/google/docsy@1b10f6bebe
go: downgraded github.com/google/docsy v0.5.1 => v0.4.1-0.20220713143414-1b10f6bebef9

@jmichelgarcia jmichelgarcia changed the title Regression in offline search on v0.5.1 Regression in offline search popover on v0.5.1 Nov 3, 2022
tekezo added a commit to tekezo/docsy that referenced this issue Nov 3, 2022
@tekezo
Copy link
Contributor

tekezo commented Nov 3, 2022

Thank you for feedback.

I guess this is an issue with the bootstrap update.
I've created a PR for the fix. #1305

@chalin @LisaFC Could you review the PR?

chalin pushed a commit to tekezo/docsy that referenced this issue Nov 3, 2022
@chalin
Copy link
Collaborator

chalin commented Nov 3, 2022

Thanks for the detailed report @jmichelgarcia. Let us know if this fix worked for you. Thanks for the fix @tekezo.

@tekezo
Copy link
Contributor

tekezo commented Nov 3, 2022

@chalin Thanks for reviewing!

@jmichelgarcia I've confirmed the fix with the following version specification:

hugo mod get github.com/google/docsy@e6a44dff7eb73ee4abd058ca0ee6dc7d18a941f1

@jmichelgarcia
Copy link
Author

It's puuuurfect. Thank you folks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants