Docsy SCSS overriding Hugo 0.60+ highlight style

[kmuncie]

The background colors set below seem to be overriding the native Hugo highlight styles after upgrading to Hugo 0.60+

• https://github.com/google/docsy/blob/master/assets/scss/_code.scss#L10
• https://github.com/google/docsy/blob/master/assets/scss/_code.scss#L41

This is especially noticeable with the darker code style themes such as the default theme of monokai as seen below:

Thank you for your time looking at this.

[LisaFC]

Thanks for spotting that, I'll take a look.

[frodriguezsmartclip]

@kmuncie yeah, therefore I've configured the Prism.JS to highlight code in my custom theme docsy. So, I dont have to depend if Hugo change the settings for highlighting or something became overriding in theme...

Here I explain better.

Regards!! ;)

[ghost]

@LisaFC, any updates on this? the issue still persists.

[LisaFC]

Thanks for the reminder! Will try to look at it this week.

[ghost]

hey @LisaFC, Sorry to bother again, but any chance you could take a look at this soon :)

[LisaFC]

Hey, sorry for the late reply (I was on vacation), I will try to get to it this week along with catching up on the day job. :)

[LisaFC]

OK, I've fixed it but need to make sure it doesn't do anything really bizarre for people using pre-0.60 Hugo.

Might do a quick survey on the mailing list....

[LisaFC]

One other thought is that if you don't specify a language for the block you don't get your chosen highlight formatting (it's just black text on a grey background) but I think that's a Hugo thing rather than anything in our CSS. You can get around it by setting "guessSyntax" to "true" and then all fenced code blocks end up in a highlight div (it hasn't given me anything particularly odd yet, but...).

Also my fix definitely gives ok results deploying with 0.59 so I think I'll get a PR together.

[LisaFC]

Have a look at #312. It does mean that users who update to the latest template will also need to update their config.toml files if they don't want to use Monokai, but maybe that's ok?

[ghost]

Hey @LisaFC ,just tested it, everything working for me. Thanks a lot. 👍 🙏

Hugo version:
Hugo Static Site Generator v0.68.3-157669A0/extended linux/amd64 BuildDate: 2020-03-24T12:13:38Z