Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BS5] Adjust HTML of dropdowns for version and lang #1415

Merged
merged 1 commit into from
Feb 14, 2023
Merged

[BS5] Adjust HTML of dropdowns for version and lang #1415

merged 1 commit into from
Feb 14, 2023

Conversation

chalin
Copy link
Collaborator

@chalin chalin commented Feb 13, 2023

  • Contributes to Upgrade to Bootstrap 5.2 #470
  • Updates the HTML generated for the nav versions and languages dropdown. The updates were made according to ttps://getbootstrap.com/docs/5.3/components/dropdowns/

Screenshot (with a versions menu added)

image

@chalin chalin requested a review from deining February 13, 2023 23:43
@chalin chalin mentioned this pull request Feb 13, 2023
Closed
50 tasks
@chalin chalin merged commit 57d3d42 into google:main Feb 14, 2023
@chalin chalin deleted the chalin-im-dropdown-bs5-2023-02-13 branch February 14, 2023 11:22
@chalin
Copy link
Collaborator Author

chalin commented Feb 14, 2023

Merged, but as always, feedback is welcome @deining et al.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deining deining Awaiting requested review from deining

Assignees
No one assigned
Labels
bootstrap
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@chalin