Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make automatic detection of draw.io diagrams an opt-in #1470

Merged
merged 7 commits into from
May 31, 2023

Conversation

deining
Copy link
Collaborator

@deining deining commented Mar 8, 2023

This PR addresses #1185. It makes automatic detection of draw.io diagrams an opt-in. It also reflects these breaking change in the user guide and in the change log.

This PR closes #1185.


Preview: https://deploy-preview-1470--docsydocs.netlify.app/docs/adding-content/diagrams-and-formulae/#diagrams-with-diagramsnet

@deining deining requested a review from chalin March 8, 2023 21:12
@deining deining force-pushed the draw.io-enable branch 3 times, most recently from aaa1a8f to bd8cee5 Compare May 25, 2023 19:37
Copy link
Collaborator

@chalin chalin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@chalin chalin changed the title Make automatic detection of draw.io diagrams an opt-in (#1185) Make automatic detection of draw.io diagrams an opt-in May 31, 2023
@chalin chalin merged commit 00b97f4 into google:main May 31, 2023
@deining deining deleted the draw.io-enable branch June 11, 2023 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

drawio support should be opt-in not opt-out
2 participants