Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop mycplus.com iframe from Shortcode page #1475

Merged
merged 1 commit into from
May 4, 2023

Conversation

chalin
Copy link
Collaborator

@chalin chalin commented Mar 10, 2023

  • Closes Consider removing/changing the iframe to mycplus.com #1468
  • Drop the mycplus.com iframe from Shortcode page so now a page refresh, on my machines takes < 400 ms as compared to 5+ sec. The section immediately after contains an example of a {{< tab ... right=true text=true >}}, so nothing is lost.
  • Whitespace cleanup in various code blocks

@chalin chalin added the user guide Improvements to user guide label Mar 10, 2023
@chalin chalin requested review from LisaFC, deining and geriom March 10, 2023 12:21
@@ -388,9 +383,6 @@ object HelloWorld extends App {
println("Hello world!")
}
{{< /tab >}}
{{< tab header="Reference" right=true text=true >}}
Copy link
Collaborator

@deining deining Mar 10, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree that www.mycplus.com needs to be replaced or removed.

What about replacing it with http://helloworldcollection.de:

{{< /tab >}}
{{< tab header="Reference" right=true text=true >}}
{{< iframe src="http://helloworldcollection.de" >}}
{{< /tab >}}

This site loads ways faster.

@chalin chalin force-pushed the chalin-im-drop-myc-iframe-2023-03-10 branch from 5c11902 to c090f38 Compare May 4, 2023 14:19
@chalin
Copy link
Collaborator Author

chalin commented May 4, 2023

This was discussed during the March PSC meeting, and we agreed to drop the iframe, especially since it is secondary to that section (which is for tabbed panes). As remarked in the notes:

If we do choose to reintroduce an iframe, especially hidden under a tab, then it should be fully lazily loaded. (But I don't want to have to deal with that until BSv5 release of Docsy is out).

I'm going to merge this now since I keep hitting the iframe-loading delays during my BSv5 migration work, and I'm trying to wrap this up the BSv5 work ASAP. As mentioned above, we can look into re-introducing an iframe (if we feel that is important enough), provided it gets lazily loaded.

@chalin chalin merged commit dbec296 into google:main May 4, 2023
@chalin chalin deleted the chalin-im-drop-myc-iframe-2023-03-10 branch May 4, 2023 14:26
@chalin chalin mentioned this pull request May 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
user guide Improvements to user guide
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Consider removing/changing the iframe to mycplus.com
2 participants