Tabpane shortcodes: improved reporting of warnings and errors #1478
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chalin
force-pushed
the
improve-tab-shortcode
branch
from
280b1d8 to
45acc8d
Compare
chalin
force-pushed
the
improve-tab-shortcode
branch
from
45acc8d to
83be7b5
Compare
|
After rebasing, the build is failing. Can you take a look @deining?
|
|
The good think about the error, is that it tested the new error reporting code. It's great to be able to click and have VS Code deep link to the point of error! I committed a minor fix to the docs. The build is now passing. |
chalin
approved these changes
May 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR follows up on #1448: Tabpane warning: make it easier to find source page.
Only now I realized that we can do even better here and report not only the source page, but also the offending position (line number) inside the page.
This PR improves various error messsages, they all report the position of the offending code now. Also the wording was improved for several messages, making them easier to understand.