Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump dependency Font-Awesome to latest version 6.4.0 #1529

Merged
merged 1 commit into from
Jun 1, 2023

Conversation

deining
Copy link
Collaborator

@deining deining commented Jun 1, 2023

This PR bumps dependency Font-Awesome to latest released version 6.4.0.

@deining deining force-pushed the font-awesome-6.4.0 branch from eeeb9c0 to 492b770 Compare June 1, 2023 15:52
Copy link
Collaborator

@chalin chalin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Collaborator

@chalin chalin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@chalin
Copy link
Collaborator

chalin commented Jun 1, 2023

Sampled several pages of before / after and they seem identical -- so no major changes between the dot releases of FA \o/

@chalin chalin merged commit ff18182 into google:main Jun 1, 2023
"hugo-extended": "0.110.0"
"hugo-extended": "0.112.3"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Darn, I missed this update to hugo-extended, and it's causing build issues.

In general, @deining please avoid slipping in an unrelated change (the title of this PR is about FA), or make it very clear in the tilte and/or description that there's more.

I'm going to revert this change and address the Hugo update separately.

@deining deining deleted the font-awesome-6.4.0 branch June 8, 2023 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants