Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added Support for Canonical page link in <head> #2032

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Added Support for Canonical page link in <head> #2032

wants to merge 1 commit into from

Conversation

iArchitSharma
Copy link
Contributor

This PR fixes #2010 #1537

this code generates a canonical link tag for a webpage based on the value of the canonical_url parameter in the content file's front matter. If the parameter is not defined, it falls back to the permalink of the page, ensuring that search engines understand the preferred URL for the page.

@iArchitSharma
Added Support for Canonical page link in <head>
16543fd 
Signed-off-by: Archit Sharma <74408634+iArchitSharma@users.noreply.github.com>
@iArchitSharma iArchitSharma mentioned this pull request Jun 3, 2024
Open
@fekete-robert
Copy link
Collaborator

Hi, thanks for the PR!
I think this functionality should go directly into layouts/partials/head.html, or into a separate partial that's included in head.html.
The head-end hook is not a good place for it, because that's a placeholder file and many projects override it with their own code.

@chalin chalin marked this pull request as draft June 4, 2024 21:25
@chalin
Copy link
Collaborator

chalin commented Jun 4, 2024

Hi @iArchitSharma - it looks like you copied the file that I put together for the OTel.io site. Is that the case? If so, then that file is a partial experimental design (I still have work to do on it), and it isn't suitable, in it's current form, for inclusion in Docsy yet.

@iArchitSharma
Copy link
Contributor Author

@fekete-robert, thanks for the info. I'll move this functionality to head directly then.

@iArchitSharma
Copy link
Contributor Author

Yes, @chalin, I copied this from the OTel.io site. Although when I tested it, it seemed to work as intended. What improvements are needed here? I would love to help

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[i18n] Canonical page link of a fallback page should refer to default language page
3 participants
@iArchitSharma @fekete-robert @chalin