Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[0.5.x] Create v0.5.1+2 "patch" without devDep #2140

Merged

Conversation

chalin
Copy link
Collaborator

@chalin chalin commented Dec 8, 2024

When using docsy as an NPM module either directly from GitHub or via a path, devDeps get installed too, and this seems to cause problems for projects using Docsy in some containerized environments (like what we're trying to do in kubernetes/website#48812). This patch effectively hides the devDep.

@chalin
Copy link
Collaborator Author

chalin commented Dec 8, 2024

Note that this PR contains an intermediate commit that experiments with the NPM package name @docsy/theme for Docsy. I'm keeping the commit but have overridden the changes. We'll consider implementing this, or not, at HEAD if when the need arises.

@chalin chalin merged commit cc85743 into google:v0.5.x Dec 8, 2024
1 check passed
@chalin chalin deleted the chalin-im-0.5.1+2-deps-patch-2024-12-07 branch December 8, 2024 02:35
@chalin chalin added this to the 24Q4 milestone Jan 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant