Fix some compile warnings in Visual Studio #188
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
|
Thanks for the pull request. |
floitsch
requested changes
Aug 26, 2022
double-conversion/bignum.cc
Outdated
| @@ -147,7 +147,7 @@ void Bignum::AssignHexString(Vector<const char> value) { | |||
| } | |||
| if (tmp > 0) { | |||
| DOUBLE_CONVERSION_ASSERT(tmp <= kBigitMask); | |||
| RawBigit(used_bigits_++) = (tmp & kBigitMask); | |||
| RawBigit(used_bigits_++) = (Bignum::Chunk)(tmp & kBigitMask); | |||
There was a problem hiding this comment.
Please change to C++ static_cast<Bignum::Chunk> casts. Here and for the others.
double-conversion/bignum.cc.patch
Outdated
| @@ -0,0 +1,51 @@ | |||
| Index: bignum.cc | |||
|
Thanks for the PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are some changes I made to get double-conversion to compile without warnings in Visual Studio 2012.
I had to manually make the changes for this pull request, code is not tested! (my local double-conversion is slightly different and in SVN)